Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: scripts/slave/recipe_modules/chromium_android/api.py

Issue 2252553002: Add cs-base-url, store_tombstones, master_name for android inst tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/chromium_android/api.py
diff --git a/scripts/slave/recipe_modules/chromium_android/api.py b/scripts/slave/recipe_modules/chromium_android/api.py
index c5aaf39e75a1cffe99a208887aaf3c6d1c26b949..ed1075a4e244901a176a5b17bceee02ab9e8298a 100644
--- a/scripts/slave/recipe_modules/chromium_android/api.py
+++ b/scripts/slave/recipe_modules/chromium_android/api.py
@@ -850,6 +850,8 @@ class AndroidApi(recipe_api.RecipeApi):
device_flags=None,
wrapper_script_suite_name=None,
result_details=False,
+ master_name = None,
jbudorick 2016/08/16 00:32:06 nit: no spaces around =
BigBossZhiling 2016/08/16 00:46:25 Done.
+ cs_base_url = None,
**kwargs):
args = [
'--blacklist-file', self.blacklist_file,
@@ -912,13 +914,18 @@ class AndroidApi(recipe_api.RecipeApi):
with self.m.step.nest('process results for %s' % step_name):
try:
details_html = details_dir.join('details.html')
+ presentation_args = ['--json-file',
+ json_results_file,
+ '--html-file',
+ details_html]
+ if master_name:
+ presentation_args.extend(['--master-name', master_name])
+ if cs_base_url:
+ presentation_args.extend(['--cs-base-url', cs_base_url])
self.m.python(
'Generate Result Details',
self.resource('test_results_presentation.py'),
- args=['--json-file',
- json_results_file,
- '--html-file',
- details_html])
+ args=presentation_args)
details_list = self.m.file.read(
'Read detail.html',
details_html,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698