Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 2252553002: Add cs-base-url, store_tombstones, master_name for android inst tests. (Closed)

Created:
4 years, 4 months ago by BigBossZhiling
Modified:
4 years, 4 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Add --cs-base-url and --master-name for android inst tests. --cs-base-url is an argument that specifies the code search base url in the test results presentation html generated by the results of android instrumentation tests. --master-name is an argument that specifies master name. --store-tombstones specified whether to store tombstones when a testcase crashes. In this cl, these two arguments are added to instrumentation test run and are default to none. BUG=605572 Committed: https://chromium.googlesource.com/chromium/tools/build/+/4e323b91fca31f987f70a57b5ac3e3d96fdeb26c

Patch Set 1 #

Total comments: 2

Patch Set 2 : added a sample in example.py #

Total comments: 4

Patch Set 3 : removed master name #

Patch Set 4 : added --store-tombstones argument #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -7 lines) Patch
M scripts/slave/recipe_modules/chromium_android/api.py View 1 2 3 3 chunks +13 lines, -4 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.py View 1 2 3 3 chunks +5 lines, -2 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_android/example.expected/result_details_basic.json View 1 2 3 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 14 (4 generated)
BigBossZhiling
4 years, 4 months ago (2016-08-15 23:17:34 UTC) #2
BigBossZhiling
Is there a train/simulate command that I should run for this?
4 years, 4 months ago (2016-08-15 23:18:24 UTC) #3
jbudorick
Add a sample use to recipe_modules/chromium_android/example.py and retrain expectations. https://codereview.chromium.org/2252553002/diff/1/scripts/slave/recipe_modules/chromium_android/api.py File scripts/slave/recipe_modules/chromium_android/api.py (right): https://codereview.chromium.org/2252553002/diff/1/scripts/slave/recipe_modules/chromium_android/api.py#newcode853 scripts/slave/recipe_modules/chromium_android/api.py:853: ...
4 years, 4 months ago (2016-08-16 00:32:06 UTC) #4
BigBossZhiling
https://codereview.chromium.org/2252553002/diff/1/scripts/slave/recipe_modules/chromium_android/api.py File scripts/slave/recipe_modules/chromium_android/api.py (right): https://codereview.chromium.org/2252553002/diff/1/scripts/slave/recipe_modules/chromium_android/api.py#newcode853 scripts/slave/recipe_modules/chromium_android/api.py:853: master_name = None, On 2016/08/16 00:32:06, jbudorick wrote: > ...
4 years, 4 months ago (2016-08-16 00:46:25 UTC) #5
jbudorick
https://codereview.chromium.org/2252553002/diff/20001/scripts/slave/recipe_modules/chromium_android/api.py File scripts/slave/recipe_modules/chromium_android/api.py (right): https://codereview.chromium.org/2252553002/diff/20001/scripts/slave/recipe_modules/chromium_android/api.py#newcode853 scripts/slave/recipe_modules/chromium_android/api.py:853: master_name=None, Remove this argument. https://codereview.chromium.org/2252553002/diff/20001/scripts/slave/recipe_modules/chromium_android/api.py#newcode922 scripts/slave/recipe_modules/chromium_android/api.py:922: presentation_args.extend(['--master-name', master_name]) Just ...
4 years, 4 months ago (2016-08-17 04:15:28 UTC) #6
BigBossZhiling
https://codereview.chromium.org/2252553002/diff/20001/scripts/slave/recipe_modules/chromium_android/api.py File scripts/slave/recipe_modules/chromium_android/api.py (right): https://codereview.chromium.org/2252553002/diff/20001/scripts/slave/recipe_modules/chromium_android/api.py#newcode853 scripts/slave/recipe_modules/chromium_android/api.py:853: master_name=None, On 2016/08/17 04:15:28, jbudorick wrote: > Remove this ...
4 years, 4 months ago (2016-08-17 22:38:27 UTC) #7
BigBossZhiling
added --store-tombstones argument
4 years, 4 months ago (2016-08-17 23:28:33 UTC) #9
jbudorick
lgtm
4 years, 4 months ago (2016-08-18 13:57:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2252553002/60001
4 years, 4 months ago (2016-08-18 16:11:18 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 16:18:16 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/tools/build/+/4e323b91fca31f987f70...

Powered by Google App Engine
This is Rietveld 408576698