Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(936)

Issue 2252543002: cc: Introduce a max ideal contents scale constant. (Closed)

Created:
4 years, 4 months ago by vmpstr
Modified:
4 years, 4 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Introduce a max ideal contents scale constant. This patch adds a max ideal contents scale constant set to 10000.f. This prevents overflow/badness issues that result from a contents scale that is too large. R=enne BUG=633148, 635511 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/a6aa89c844fa8a2769460131b594382e8347da2b Cr-Commit-Position: refs/heads/master@{#412093}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M cc/layers/picture_layer_impl.cc View 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
vmpstr
Please take a look.
4 years, 4 months ago (2016-08-15 22:24:05 UTC) #2
enne (OOO)
lgtm
4 years, 4 months ago (2016-08-15 22:26:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2252543002/1
4 years, 4 months ago (2016-08-15 22:27:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-15 23:28:12 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 23:32:03 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a6aa89c844fa8a2769460131b594382e8347da2b
Cr-Commit-Position: refs/heads/master@{#412093}

Powered by Google App Engine
This is Rietveld 408576698