Only test SVG DM sources against direct raster/gpu sinks.

Only test SVG DM sources against direct raster/gpu sinks.

There isn't much value in testing against indirect or vector sinks.

R=mtklein@google.com,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2252443002

Committed: https://skia.googlesource.com/skia/+/179d88522c3cdd49480e34482c29a8afb027a6ad

[f(malita), 2016-08-15 20:18:36]

Description was changed from

==========
Only test SVG DM sources against (raster && direct) sinks.

R=mtklein@google.com,robertphillips@google.com
==========

to

==========
Only test SVG DM sources against (raster && direct) sinks.

R=mtklein@google.com,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2252443002
==========

[f(malita), 2016-08-15 20:20:54]

Description was changed from

==========
Only test SVG DM sources against (raster && direct) sinks.

R=mtklein@google.com,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2252443002
==========

to

==========
Only test SVG DM sources against direct raster/gpu sinks.

There isn't much value in testing against indirect or vector sinks.

R=mtklein@google.com,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2252443002
==========

[f(malita), 2016-08-15 20:27:34]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 20:27:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mtklein, 2016-08-15 20:35:37]

https://codereview.chromium.org/2252443002/diff/20001/dm/DMSrcSink.cpp
File dm/DMSrcSink.cpp (right):

https://codereview.chromium.org/2252443002/diff/20001/dm/DMSrcSink.cpp#newcod...
dm/DMSrcSink.cpp:1059: return (flags.type != SinkFlags::kRaster && flags.type !=
SinkFlags::kGPU)
maybe

bool type_ok = flags.type == SinkFlags::kRaster
            || flags.type == SinkFlags::kGPU;

return !type_ok || flags.approach != SinkFlags::kDirect;

[mtklein, 2016-08-15 20:36:04]

(lgtm though)

[commit-bot: I haz the power, 2016-08-15 21:09:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 21:09:26]

Dry run: This issue passed the CQ dry run.

[f(malita), 2016-08-16 20:59:00]

https://codereview.chromium.org/2252443002/diff/20001/dm/DMSrcSink.cpp
File dm/DMSrcSink.cpp (right):

https://codereview.chromium.org/2252443002/diff/20001/dm/DMSrcSink.cpp#newcod...
dm/DMSrcSink.cpp:1059: return (flags.type != SinkFlags::kRaster && flags.type !=
SinkFlags::kGPU)
On 2016/08/15 20:35:37, mtklein wrote:
> maybe
> 
> bool type_ok = flags.type == SinkFlags::kRaster
>             || flags.type == SinkFlags::kGPU;
> 
> return !type_ok || flags.approach != SinkFlags::kDirect;

Done.

[f(malita), 2016-08-16 20:59:03]

The CQ bit was checked by fmalita@chromium.org

[f(malita), 2016-08-16 20:59:03]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/2252443002/#ps40001
(title: "review")

[commit-bot: I haz the power, 2016-08-16 20:59:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-16 21:23:31]

Description was changed from

==========
Only test SVG DM sources against direct raster/gpu sinks.

There isn't much value in testing against indirect or vector sinks.

R=mtklein@google.com,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2252443002
==========

to

==========
Only test SVG DM sources against direct raster/gpu sinks.

There isn't much value in testing against indirect or vector sinks.

R=mtklein@google.com,robertphillips@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2252443002

Committed:
https://skia.googlesource.com/skia/+/179d88522c3cdd49480e34482c29a8afb027a6ad
==========

[commit-bot: I haz the power, 2016-08-16 21:23:32]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/179d88522c3cdd49480e34482c29a8afb027a6ad