Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: extensions/browser/value_store/value_store_change_unittest.cc

Issue 2252373002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/value_store/value_store_change_unittest.cc
diff --git a/extensions/browser/value_store/value_store_change_unittest.cc b/extensions/browser/value_store/value_store_change_unittest.cc
index 1d92a8a2d32f15eeca5b78e83e144d2981f5c595..ef4934a72e7f7715f2e3d672728beff1c763e352 100644
--- a/extensions/browser/value_store/value_store_change_unittest.cc
+++ b/extensions/browser/value_store/value_store_change_unittest.cc
@@ -20,7 +20,7 @@ namespace {
TEST(ValueStoreChangeTest, NullOldValue) {
ValueStoreChange change("key", nullptr,
- base::WrapUnique(new base::StringValue("value")));
+ base::MakeUnique<base::StringValue>("value"));
EXPECT_EQ("key", change.key());
EXPECT_EQ(NULL, change.old_value());
@@ -31,8 +31,8 @@ TEST(ValueStoreChangeTest, NullOldValue) {
}
TEST(ValueStoreChangeTest, NullNewValue) {
- ValueStoreChange change(
- "key", base::WrapUnique(new base::StringValue("value")), nullptr);
+ ValueStoreChange change("key", base::MakeUnique<base::StringValue>("value"),
+ nullptr);
EXPECT_EQ("key", change.key());
{
@@ -44,8 +44,8 @@ TEST(ValueStoreChangeTest, NullNewValue) {
TEST(ValueStoreChangeTest, NonNullValues) {
ValueStoreChange change("key",
- base::WrapUnique(new base::StringValue("old_value")),
- base::WrapUnique(new base::StringValue("new_value")));
+ base::MakeUnique<base::StringValue>("old_value"),
+ base::MakeUnique<base::StringValue>("new_value"));
EXPECT_EQ("key", change.key());
{

Powered by Google App Engine
This is Rietveld 408576698