Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: extensions/browser/guest_view/web_view/web_view_guest.cc

Issue 2252373002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/guest_view/web_view/web_view_guest.cc
diff --git a/extensions/browser/guest_view/web_view/web_view_guest.cc b/extensions/browser/guest_view/web_view/web_view_guest.cc
index 5424db93d4ef0a12ae8b425dc82d1411fab5d169..728d701b049549565c2db6af9de4ed4e5da1b031 100644
--- a/extensions/browser/guest_view/web_view/web_view_guest.cc
+++ b/extensions/browser/guest_view/web_view/web_view_guest.cc
@@ -374,8 +374,8 @@ void WebViewGuest::DidAttachToEmbedder() {
void WebViewGuest::DidDropLink(const GURL& url) {
std::unique_ptr<base::DictionaryValue> args(new base::DictionaryValue());
args->SetString(guest_view::kUrl, url.spec());
- DispatchEventToView(base::WrapUnique(
- new GuestViewEvent(webview::kEventDropLink, std::move(args))));
+ DispatchEventToView(base::MakeUnique<GuestViewEvent>(webview::kEventDropLink,
+ std::move(args)));
}
void WebViewGuest::DidInitialize(const base::DictionaryValue& create_params) {
@@ -429,8 +429,8 @@ void WebViewGuest::ClearDataInternal(base::Time remove_since,
void WebViewGuest::GuestViewDidStopLoading() {
std::unique_ptr<base::DictionaryValue> args(new base::DictionaryValue());
- DispatchEventToView(base::WrapUnique(
- new GuestViewEvent(webview::kEventLoadStop, std::move(args))));
+ DispatchEventToView(base::MakeUnique<GuestViewEvent>(webview::kEventLoadStop,
+ std::move(args)));
}
void WebViewGuest::EmbedderFullscreenToggled(bool entered_fullscreen) {
@@ -484,8 +484,8 @@ void WebViewGuest::GuestSizeChangedDueToAutoSize(const gfx::Size& old_size,
args->SetInteger(webview::kOldWidth, old_size.width());
args->SetInteger(webview::kNewHeight, new_size.height());
args->SetInteger(webview::kNewWidth, new_size.width());
- DispatchEventToView(base::WrapUnique(
- new GuestViewEvent(webview::kEventSizeChanged, std::move(args))));
+ DispatchEventToView(base::MakeUnique<GuestViewEvent>(
+ webview::kEventSizeChanged, std::move(args)));
}
bool WebViewGuest::IsAutoSizeSupported() const {
@@ -500,8 +500,8 @@ void WebViewGuest::GuestZoomChanged(double old_zoom_level,
std::unique_ptr<base::DictionaryValue> args(new base::DictionaryValue());
args->SetDouble(webview::kOldZoomFactor, old_zoom_factor);
args->SetDouble(webview::kNewZoomFactor, new_zoom_factor);
- DispatchEventToView(base::WrapUnique(
- new GuestViewEvent(webview::kEventZoomChange, std::move(args))));
+ DispatchEventToView(base::MakeUnique<GuestViewEvent>(
+ webview::kEventZoomChange, std::move(args)));
}
void WebViewGuest::WillDestroy() {
@@ -520,15 +520,15 @@ bool WebViewGuest::AddMessageToConsole(WebContents* source,
args->SetString(webview::kMessage, message);
args->SetInteger(webview::kLine, line_no);
args->SetString(webview::kSourceId, source_id);
- DispatchEventToView(base::WrapUnique(
- new GuestViewEvent(webview::kEventConsoleMessage, std::move(args))));
+ DispatchEventToView(base::MakeUnique<GuestViewEvent>(
+ webview::kEventConsoleMessage, std::move(args)));
return true;
}
void WebViewGuest::CloseContents(WebContents* source) {
std::unique_ptr<base::DictionaryValue> args(new base::DictionaryValue());
- DispatchEventToView(base::WrapUnique(
- new GuestViewEvent(webview::kEventClose, std::move(args))));
+ DispatchEventToView(
+ base::MakeUnique<GuestViewEvent>(webview::kEventClose, std::move(args)));
}
void WebViewGuest::FindReply(WebContents* source,
@@ -578,8 +578,8 @@ void WebViewGuest::LoadProgressChanged(WebContents* source, double progress) {
std::unique_ptr<base::DictionaryValue> args(new base::DictionaryValue());
args->SetString(guest_view::kUrl, web_contents()->GetURL().spec());
args->SetDouble(webview::kProgress, progress);
- DispatchEventToView(base::WrapUnique(
- new GuestViewEvent(webview::kEventLoadProgress, std::move(args))));
+ DispatchEventToView(base::MakeUnique<GuestViewEvent>(
+ webview::kEventLoadProgress, std::move(args)));
}
void WebViewGuest::LoadAbort(bool is_top_level,
@@ -591,8 +591,8 @@ void WebViewGuest::LoadAbort(bool is_top_level,
args->SetString(guest_view::kUrl, url.possibly_invalid_spec());
args->SetInteger(guest_view::kCode, error_code);
args->SetString(guest_view::kReason, error_type);
- DispatchEventToView(base::WrapUnique(
- new GuestViewEvent(webview::kEventLoadAbort, std::move(args))));
+ DispatchEventToView(base::MakeUnique<GuestViewEvent>(webview::kEventLoadAbort,
+ std::move(args)));
}
void WebViewGuest::SetContextMenuPosition(const gfx::Point& position) {
@@ -643,16 +643,16 @@ void WebViewGuest::RendererResponsive(WebContents* source) {
std::unique_ptr<base::DictionaryValue> args(new base::DictionaryValue());
args->SetInteger(webview::kProcessId,
web_contents()->GetRenderProcessHost()->GetID());
- DispatchEventToView(base::WrapUnique(
- new GuestViewEvent(webview::kEventResponsive, std::move(args))));
+ DispatchEventToView(base::MakeUnique<GuestViewEvent>(
+ webview::kEventResponsive, std::move(args)));
}
void WebViewGuest::RendererUnresponsive(WebContents* source) {
std::unique_ptr<base::DictionaryValue> args(new base::DictionaryValue());
args->SetInteger(webview::kProcessId,
web_contents()->GetRenderProcessHost()->GetID());
- DispatchEventToView(base::WrapUnique(
- new GuestViewEvent(webview::kEventUnresponsive, std::move(args))));
+ DispatchEventToView(base::MakeUnique<GuestViewEvent>(
+ webview::kEventUnresponsive, std::move(args)));
}
void WebViewGuest::Observe(int type,
@@ -818,8 +818,8 @@ void WebViewGuest::DidCommitProvisionalLoadForFrame(
web_contents()->GetController().GetEntryCount());
args->SetInteger(webview::kInternalProcessId,
web_contents()->GetRenderProcessHost()->GetID());
- DispatchEventToView(base::WrapUnique(
- new GuestViewEvent(webview::kEventLoadCommit, std::move(args))));
+ DispatchEventToView(base::MakeUnique<GuestViewEvent>(
+ webview::kEventLoadCommit, std::move(args)));
find_helper_.CancelAllFindSessions();
}
@@ -846,8 +846,8 @@ void WebViewGuest::DidStartProvisionalLoadForFrame(
std::unique_ptr<base::DictionaryValue> args(new base::DictionaryValue());
args->SetString(guest_view::kUrl, validated_url.spec());
args->SetBoolean(guest_view::kIsTopLevel, !render_frame_host->GetParent());
- DispatchEventToView(base::WrapUnique(
- new GuestViewEvent(webview::kEventLoadStart, std::move(args))));
+ DispatchEventToView(base::MakeUnique<GuestViewEvent>(webview::kEventLoadStart,
+ std::move(args)));
}
void WebViewGuest::RenderProcessGone(base::TerminationStatus status) {
@@ -858,8 +858,8 @@ void WebViewGuest::RenderProcessGone(base::TerminationStatus status) {
args->SetInteger(webview::kProcessId,
web_contents()->GetRenderProcessHost()->GetID());
args->SetString(webview::kReason, TerminationStatusToString(status));
- DispatchEventToView(base::WrapUnique(
- new GuestViewEvent(webview::kEventExit, std::move(args))));
+ DispatchEventToView(
+ base::MakeUnique<GuestViewEvent>(webview::kEventExit, std::move(args)));
}
void WebViewGuest::UserAgentOverrideSet(const std::string& user_agent) {
@@ -886,14 +886,14 @@ void WebViewGuest::ReportFrameNameChange(const std::string& name) {
name_ = name;
std::unique_ptr<base::DictionaryValue> args(new base::DictionaryValue());
args->SetString(webview::kName, name);
- DispatchEventToView(base::WrapUnique(
- new GuestViewEvent(webview::kEventFrameNameChanged, std::move(args))));
+ DispatchEventToView(base::MakeUnique<GuestViewEvent>(
+ webview::kEventFrameNameChanged, std::move(args)));
}
void WebViewGuest::LoadHandlerCalled() {
std::unique_ptr<base::DictionaryValue> args(new base::DictionaryValue());
- DispatchEventToView(base::WrapUnique(
- new GuestViewEvent(webview::kEventContentLoad, std::move(args))));
+ DispatchEventToView(base::MakeUnique<GuestViewEvent>(
+ webview::kEventContentLoad, std::move(args)));
}
void WebViewGuest::LoadRedirect(const GURL& old_url,
@@ -903,8 +903,8 @@ void WebViewGuest::LoadRedirect(const GURL& old_url,
args->SetBoolean(guest_view::kIsTopLevel, is_top_level);
args->SetString(webview::kNewURL, new_url.spec());
args->SetString(webview::kOldURL, old_url.spec());
- DispatchEventToView(base::WrapUnique(
- new GuestViewEvent(webview::kEventLoadRedirect, std::move(args))));
+ DispatchEventToView(base::MakeUnique<GuestViewEvent>(
+ webview::kEventLoadRedirect, std::move(args)));
}
void WebViewGuest::PushWebViewStateToIOThread() {
@@ -1497,8 +1497,8 @@ void WebViewGuest::SetFullscreenState(bool is_fullscreen) {
// Dispatch a message so we can call document.webkitCancelFullscreen()
// on the embedder.
std::unique_ptr<base::DictionaryValue> args(new base::DictionaryValue());
- DispatchEventToView(base::WrapUnique(
- new GuestViewEvent(webview::kEventExitFullscreen, std::move(args))));
+ DispatchEventToView(base::MakeUnique<GuestViewEvent>(
+ webview::kEventExitFullscreen, std::move(args)));
}
// Since we changed fullscreen state, sending a Resize message ensures that
// renderer/ sees the change.

Powered by Google App Engine
This is Rietveld 408576698