extensions/browser/api/serial/serial_connection.cc - Issue 2252373002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/serial/serial_connection.cc

Issue 2252373002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/networking_config/networking_config_service_factory.cc ('k') | extensions/browser/api/sockets_tcp/sockets_tcp_api_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/serial/serial_connection.cc

diff --git a/extensions/browser/api/serial/serial_connection.cc b/extensions/browser/api/serial/serial_connection.cc

index da75595cc17e4ef2287ac52698bca37e241c2636..db7e6197e6759313b042546a3224bc5151e14920 100644

--- a/extensions/browser/api/serial/serial_connection.cc

+++ b/extensions/browser/api/serial/serial_connection.cc

@@ -225,9 +225,9 @@ bool SerialConnection::Receive(const ReceiveCompleteCallback& callback) {

return false;

receive_complete_ = callback;

receive_buffer_ = new net::IOBuffer(buffer_size_);

- io_handler_->Read(base::WrapUnique(new device::ReceiveBuffer(

+ io_handler_->Read(base::MakeUnique<device::ReceiveBuffer>(

receive_buffer_, buffer_size_,

- base::Bind(&SerialConnection::OnAsyncReadComplete, AsWeakPtr()))));

+ base::Bind(&SerialConnection::OnAsyncReadComplete, AsWeakPtr())));

receive_timeout_task_.reset();

if (receive_timeout_ > 0) {

receive_timeout_task_.reset(new TimeoutTask(

@@ -243,8 +243,8 @@ bool SerialConnection::Send(const std::vector<char>& data,

if (!send_complete_.is_null())

return false;

send_complete_ = callback;

- io_handler_->Write(base::WrapUnique(new device::SendBuffer(

- data, base::Bind(&SerialConnection::OnAsyncWriteComplete, AsWeakPtr()))));

+ io_handler_->Write(base::MakeUnique<device::SendBuffer>(

+ data, base::Bind(&SerialConnection::OnAsyncWriteComplete, AsWeakPtr())));

send_timeout_task_.reset();

if (send_timeout_ > 0) {

send_timeout_task_.reset(new TimeoutTask(