extensions/browser/api/networking_config/networking_config_service.cc - Issue 2252373002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/networking_config/networking_config_service.cc

Issue 2252373002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/idle/idle_api_unittest.cc ('k') | extensions/browser/api/networking_config/networking_config_service_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/networking_config/networking_config_service.cc

diff --git a/extensions/browser/api/networking_config/networking_config_service.cc b/extensions/browser/api/networking_config/networking_config_service.cc

index c9240e0065ff993698999027551220194606f0f2..2d3e2e819ba994cc6463ea837e99c4d3a9ba08eb 100644

--- a/extensions/browser/api/networking_config/networking_config_service.cc

+++ b/extensions/browser/api/networking_config/networking_config_service.cc

@@ -193,9 +193,9 @@ NetworkingConfigService::CreatePortalDetectedEventAndDispatch(

network_info.type = api::networking_config::NETWORK_TYPE_WIFI;

const std::vector<uint8_t>& raw_ssid = network->raw_ssid();

std::string hex_ssid = base::HexEncode(raw_ssid.data(), raw_ssid.size());

- network_info.hex_ssid = base::WrapUnique(new std::string(hex_ssid));

- network_info.ssid = base::WrapUnique(new std::string(network->name()));

- network_info.guid = base::WrapUnique(new std::string(network->guid()));

+ network_info.hex_ssid = base::MakeUnique<std::string>(hex_ssid);

+ network_info.ssid = base::MakeUnique<std::string>(network->name());

+ network_info.guid = base::MakeUnique<std::string>(network->guid());

if (bssid)

network_info.bssid.reset(new std::string(*bssid));

std::unique_ptr<base::ListValue> results =