components/policy/core/browser/configuration_policy_pref_store_unittest.cc - Issue 2252353002: Re-write many calls to WrapUnique() with MakeUnique()

Unified Diff: components/policy/core/browser/configuration_policy_pref_store_unittest.cc

Issue 2252353002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/browser/configuration_policy_handler_unittest.cc ('k') | components/policy/core/browser/proxy_policy_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/browser/configuration_policy_pref_store_unittest.cc

diff --git a/components/policy/core/browser/configuration_policy_pref_store_unittest.cc b/components/policy/core/browser/configuration_policy_pref_store_unittest.cc

index 14d71c655e5de9e1dee59f7ec3e9ac233f91c5b5..8fae2550daf85eaf0f0691dffb1d620268b1785d 100644

--- a/components/policy/core/browser/configuration_policy_pref_store_unittest.cc

+++ b/components/policy/core/browser/configuration_policy_pref_store_unittest.cc

@@ -87,7 +87,7 @@ TEST_F(ConfigurationPolicyPrefStoreStringTest, SetValue) {

PolicyMap policy;

policy.Set(kTestPolicy, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,

POLICY_SOURCE_CLOUD,

- base::WrapUnique(new base::StringValue("http://chromium.org")),

+ base::MakeUnique<base::StringValue>("http://chromium.org"),

nullptr);

UpdateProviderPolicy(policy);

const base::Value* value = NULL;

@@ -114,7 +114,7 @@ TEST_F(ConfigurationPolicyPrefStoreBooleanTest, SetValue) {

PolicyMap policy;

policy.Set(kTestPolicy, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,

POLICY_SOURCE_CLOUD,

- base::WrapUnique(new base::FundamentalValue(false)), nullptr);

+ base::MakeUnique<base::FundamentalValue>(false), nullptr);

UpdateProviderPolicy(policy);

const base::Value* value = NULL;

EXPECT_TRUE(store_->GetValue(kTestPref, &value));

@@ -126,7 +126,7 @@ TEST_F(ConfigurationPolicyPrefStoreBooleanTest, SetValue) {

policy.Set(kTestPolicy, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,

POLICY_SOURCE_CLOUD,

- base::WrapUnique(new base::FundamentalValue(true)), nullptr);

+ base::MakeUnique<base::FundamentalValue>(true), nullptr);

UpdateProviderPolicy(policy);

value = NULL;

EXPECT_TRUE(store_->GetValue(kTestPref, &value));

@@ -153,8 +153,8 @@ TEST_F(ConfigurationPolicyPrefStoreIntegerTest, GetDefault) {

TEST_F(ConfigurationPolicyPrefStoreIntegerTest, SetValue) {

PolicyMap policy;

policy.Set(kTestPolicy, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,

- POLICY_SOURCE_CLOUD,

- base::WrapUnique(new base::FundamentalValue(2)), nullptr);

+ POLICY_SOURCE_CLOUD, base::MakeUnique<base::FundamentalValue>(2),

+ nullptr);

UpdateProviderPolicy(policy);

const base::Value* value = NULL;

EXPECT_TRUE(store_->GetValue(kTestPref, &value));

@@ -188,7 +188,7 @@ TEST_F(ConfigurationPolicyPrefStoreRefreshTest, Refresh) {

PolicyMap policy;

policy.Set(kTestPolicy, POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,

POLICY_SOURCE_CLOUD,

- base::WrapUnique(new base::StringValue("http://www.chromium.org")),

+ base::MakeUnique<base::StringValue>("http://www.chromium.org"),

nullptr);

UpdateProviderPolicy(policy);

observer_.VerifyAndResetChangedKey(kTestPref);