components/omnibox/browser/base_search_provider.cc - Issue 2252343002: Re-write many calls to WrapUnique() with MakeUnique()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/omnibox/browser/base_search_provider.cc

Issue 2252343002: Re-write many calls to WrapUnique() with MakeUnique() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/omnibox/browser/autocomplete_provider_unittest.cc ('k') | components/omnibox/browser/history_url_provider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/omnibox/browser/base_search_provider.cc

diff --git a/components/omnibox/browser/base_search_provider.cc b/components/omnibox/browser/base_search_provider.cc

index e75b9e35fe16ba2db3b32714b3279f64770b0c61..014ed758ce66763d108db86173bc4deb53d2239f 100644

--- a/components/omnibox/browser/base_search_provider.cc

+++ b/components/omnibox/browser/base_search_provider.cc

@@ -125,11 +125,11 @@ AutocompleteMatch BaseSearchProvider::CreateSearchSuggestion(

void BaseSearchProvider::DeleteMatch(const AutocompleteMatch& match) {

DCHECK(match.deletable);

if (!match.GetAdditionalInfo(BaseSearchProvider::kDeletionUrlKey).empty()) {

- deletion_handlers_.push_back(base::WrapUnique(new SuggestionDeletionHandler(

+ deletion_handlers_.push_back(base::MakeUnique<SuggestionDeletionHandler>(

match.GetAdditionalInfo(BaseSearchProvider::kDeletionUrlKey),

client_->GetRequestContext(),

base::Bind(&BaseSearchProvider::OnDeletionComplete,

- base::Unretained(this)))));

+ base::Unretained(this))));

}

TemplateURL* template_url =