MD Settings: reduce complexity and overhead of Languages singleton

chrome/browser/resources/settings/languages_page/languages_page.js

Index: chrome/browser/resources/settings/languages_page/languages_page.js
diff --git a/chrome/browser/resources/settings/languages_page/languages_page.js b/chrome/browser/resources/settings/languages_page/languages_page.js
index f36e18a738a5f5716cc606a2b77f64028616e1a4..29598dc5a489f5c20a151cfbda2dbc43e417ab93 100644
--- a/chrome/browser/resources/settings/languages_page/languages_page.js
+++ b/chrome/browser/resources/settings/languages_page/languages_page.js
@@ -43,14 +43,6 @@ Polymer({
      * @private
      */
     detailLanguage_: Object,
-
-    /** @private {!LanguageHelper} */
-    languageHelper_: Object,
-  },
-
-  /** @override */
-  created: function() {
-    this.languageHelper_ = LanguageHelperImpl.getInstance();
   },
 
   /**
@@ -65,8 +57,10 @@ Polymer({
 
     // Set the prospective UI language. This won't take effect until a restart.
     var tapEvent = /** @type {!{model: !{item: !LanguageState}}} */(e);
-    if (tapEvent.model.item.language.supportsUI)
-      this.languageHelper_.setUILanguage(tapEvent.model.item.language.code);
+    if (tapEvent.model.item.language.supportsUI) {
+      settings.LanguageHelperImpl.getInstance().setUILanguage(
+          tapEvent.model.item.language.code);
+    }
   },
 
   /**
@@ -84,8 +78,8 @@ Polymer({
    * @param {!{target: Element, model: !{item: !LanguageState}}} e
    */
   onSpellCheckChange_: function(e) {
-    this.languageHelper_.toggleSpellCheck(e.model.item.language.code,
-                                          e.target.checked);
+    settings.LanguageHelperImpl.getInstance().toggleSpellCheck(
+        e.model.item.language.code, e.target.checked);
   },
 
   /** @private */
@@ -138,7 +132,8 @@ Polymer({
    * @private
    */
   onMoveUpTap_: function(e) {
-    this.languageHelper_.moveLanguage(e.model.item.language.code, -1);
+    settings.LanguageHelperImpl.getInstance().moveLanguage(
+        e.model.item.language.code, -1);
   },
 
   /**
@@ -147,7 +142,8 @@ Polymer({
    * @private
    */
   onMoveDownTap_: function(e) {
-    this.languageHelper_.moveLanguage(e.model.item.language.code, 1);
+    settings.LanguageHelperImpl.getInstance().moveLanguage(
+        e.model.item.language.code, 1);
   },
 
   /**
@@ -183,7 +179,8 @@ Polymer({
       return;
 
     // Set the input method.
-    this.languageHelper_.setCurrentInputMethod(e.model.item.id);
+    settings.LanguageHelperImpl.getInstance().setCurrentInputMethod(
+        e.model.item.id);
   },
 
   /**
@@ -194,7 +191,8 @@ Polymer({
    */
   onInputMethodOptionsTap_: function(e) {
     assert(cr.isChromeOS);
-    this.languageHelper_.openInputMethodOptions(e.model.item.id);
+    settings.LanguageHelperImpl.getInstance().openInputMethodOptions(
+        e.model.item.id);
   },
 
   /**
@@ -257,7 +255,8 @@ Polymer({
    */
   isProspectiveUILanguage_: function(languageCode, prospectiveUILanguage) {
     assert(cr.isChromeOS || cr.isWindows);
-    return languageCode == this.languageHelper_.getProspectiveUILanguage();
+    return languageCode ==
+        settings.LanguageHelperImpl.getInstance().getProspectiveUILanguage();
   },
 
    /**
@@ -265,8 +264,9 @@ Polymer({
     * @private
     */
   getProspectiveUILanguageName_: function() {
-    return this.languageHelper_.getLanguage(
-        this.languageHelper_.getProspectiveUILanguage()).displayName;
+    var languageHelper = settings.LanguageHelperImpl.getInstance();
+    return languageHelper.getLanguage(
+        languageHelper.getProspectiveUILanguage()).displayName;
   },
 
   /**