Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5754)

Unified Diff: chrome/browser/resources/settings/languages_page/manage_languages_page.js

Issue 2252323002: MD Settings: reduce complexity and overhead of Languages singleton (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@RemoveLanguageInputMethods
Patch Set: Reduce diff Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/languages_page/manage_languages_page.js
diff --git a/chrome/browser/resources/settings/languages_page/manage_languages_page.js b/chrome/browser/resources/settings/languages_page/manage_languages_page.js
index 2de5a18198b5f0cc2b192d58723051ff3451ee13..6a247964ff03f55964e2cf1f592bf7cd9d71a17c 100644
--- a/chrome/browser/resources/settings/languages_page/manage_languages_page.js
+++ b/chrome/browser/resources/settings/languages_page/manage_languages_page.js
@@ -26,13 +26,8 @@ Polymer({
notify: true,
},
- /** @private {!LanguageHelper} */
- languageHelper_: Object,
- },
-
- /** @override */
- created: function() {
- this.languageHelper_ = LanguageHelperImpl.getInstance();
+ /** @type {!LanguageHelper} */
+ languageHelper: Object,
},
/**
@@ -43,7 +38,7 @@ Polymer({
* @private
*/
isCheckboxChecked_: function(language, change) {
- return this.languageHelper_.isLanguageEnabled(language.code);
+ return this.languageHelper.isLanguageEnabled(language.code);
},
/**
@@ -57,9 +52,9 @@ Polymer({
*/
isLanguageRequired_: function(language, change) {
// This check only applies to enabled languages.
- if (!this.languageHelper_.isLanguageEnabled(language.code))
+ if (!this.languageHelper.isLanguageEnabled(language.code))
return false;
- return !this.languageHelper_.canDisableLanguage(language.code);
+ return !this.languageHelper.canDisableLanguage(language.code);
},
/**
@@ -68,7 +63,7 @@ Polymer({
* @private
*/
onRemoveLanguageTap_: function(e) {
- this.languageHelper_.disableLanguage(e.model.item.language.code);
+ this.languageHelper.disableLanguage(e.model.item.language.code);
},
/**
@@ -80,8 +75,8 @@ Polymer({
onLanguageCheckboxChange_: function(e) {
var code = e.model.item.code;
if (e.target.checked)
- this.languageHelper_.enableLanguage(code);
+ this.languageHelper.enableLanguage(code);
else
- this.languageHelper_.disableLanguage(code);
+ this.languageHelper.disableLanguage(code);
},
});

Powered by Google App Engine
This is Rietveld 408576698