chrome/browser/resources/settings/languages_page/languages_types.js - Issue 2252323002: MD Settings: reduce complexity and overhead of Languages singleton

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/languages_page/languages_types.js

Issue 2252323002: MD Settings: reduce complexity and overhead of Languages singleton (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@RemoveLanguageInputMethods

Patch Set: Reduce diff Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/languages_page/languages_page.js ('k') | chrome/browser/resources/settings/languages_page/manage_input_methods_page.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/languages_page/languages_types.js

diff --git a/chrome/browser/resources/settings/languages_page/languages_types.js b/chrome/browser/resources/settings/languages_page/languages_types.js

index 492a1e13a50d744b8caea8984a878403876d1fa1..417ad2894677bf0c6dc650defe5fb3952e3fd5d6 100644

--- a/chrome/browser/resources/settings/languages_page/languages_types.js

+++ b/chrome/browser/resources/settings/languages_page/languages_types.js

@@ -48,10 +48,7 @@ var InputMethodsModel;

var LanguagesModel;

/**

- * Helper methods implemented by settings-languages-singleton. The nature of

- * the interaction between the singleton Polymer element and the |languages|

- * properties kept in sync is hidden from the consumer, which can just treat

- * these methods as a handy interface.

+ * Helper methods for reading and writing language settings.

* @interface

var LanguageHelper = function() {};

@@ -171,7 +168,7 @@ LanguageHelper.prototype = {

setCurrentInputMethod: assertNotReached,

/**

- * param {string} languageCode

+ * @param {string} languageCode

* @return {!Array<!chrome.languageSettingsPrivate.InputMethod>}

getInputMethodsForLanguage: assertNotReached,