Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2201)

Unified Diff: chrome/browser/resources/settings/languages_page/languages_page.html

Issue 2252323002: MD Settings: reduce complexity and overhead of Languages singleton (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@RemoveLanguageInputMethods
Patch Set: Reduce diff Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/languages_page/languages_page.html
diff --git a/chrome/browser/resources/settings/languages_page/languages_page.html b/chrome/browser/resources/settings/languages_page/languages_page.html
index 391a2bafb4d2a221ac77514707ba8d9b27d166c0..898a69ee61e58047b0ec05f7f74bc9e8e3fb9d02 100644
--- a/chrome/browser/resources/settings/languages_page/languages_page.html
+++ b/chrome/browser/resources/settings/languages_page/languages_page.html
@@ -32,7 +32,9 @@
@apply(--settings-actionable);
}
</style>
- <settings-languages languages="{{languages}}"></settings-languages>
+ <settings-languages languages="{{languages}}" prefs="{{prefs}}"
+ language-helper="{{languageHelper}}">
+ </settings-languages>
<settings-animated-pages id="pages" section="languages">
<neon-animatable route-path="default">
<div id="manage-languages-subpage-trigger"
@@ -193,13 +195,16 @@
associated-control="[[$$('#manage-languages-subpage-trigger')]]"
page-title="$i18n{manageLanguagesPageTitle}">
<settings-manage-languages-page
- prefs="{{prefs}}"></settings-manage-languages-page>
+ languages="{{languages}}" prefs="{{prefs}}"
+ language-helper="[[languageHelper]]">
+ </settings-manage-languages-page>
</settings-subpage>
</template>
<template is="dom-if" route-path="/languages/edit" no-search>
<settings-subpage page-title="[[detailLanguage_.language.displayName]]">
<settings-language-detail-page id="languageDetailPage"
- prefs="{{prefs}}" detail="[[detailLanguage_]]">
+ languages="{{languages}}" prefs="{{prefs}}"
+ detail="[[detailLanguage_]]" language-helper="[[languageHelper]]">
</settings-language-detail-page>
</settings-subpage>
</template>
@@ -208,7 +213,8 @@
<settings-subpage
associated-control="[[$$('#manage-input-methods-subpage-trigger')]]"
page-title="$i18n{manageInputMethodsPageTitle}">
- <settings-manage-input-methods-page>
+ <settings-manage-input-methods-page languages="{{languages}}"
+ language-helper="[[languageHelper]]">
</settings-manage-input-methods-page>
</settings-subpage>
</template>

Powered by Google App Engine
This is Rietveld 408576698