Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: chrome/browser/resources/settings/languages_page/language_detail_page.js

Issue 2252323002: MD Settings: reduce complexity and overhead of Languages singleton (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@RemoveLanguageInputMethods
Patch Set: Reduce diff Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/languages_page/language_detail_page.js
diff --git a/chrome/browser/resources/settings/languages_page/language_detail_page.js b/chrome/browser/resources/settings/languages_page/language_detail_page.js
index d273f5f12b8eeac47cde78c0fe94d137d152e267..fdb81f58534f45561600a3db6547c5c1d3dff09e 100644
--- a/chrome/browser/resources/settings/languages_page/language_detail_page.js
+++ b/chrome/browser/resources/settings/languages_page/language_detail_page.js
@@ -25,19 +25,14 @@ Polymer({
*/
languages: Object,
+ /** @type {!LanguageHelper} */
+ languageHelper: Object,
+
/**
* The language to display the details for.
* @type {!LanguageState|undefined}
*/
detail: Object,
-
- /** @private {!LanguageHelper} */
- languageHelper_: Object,
- },
-
- /** @override */
- created: function() {
- this.languageHelper_ = LanguageHelperImpl.getInstance();
},
/** @override */
@@ -69,7 +64,7 @@ Polymer({
*/
isProspectiveUILanguage_: function(languageCode, prospectiveUILanguage) {
assert(cr.isChromeOS || cr.isWindows);
- return languageCode == this.languageHelper_.getProspectiveUILanguage();
+ return languageCode == this.languageHelper.getProspectiveUILanguage();
},
/**
@@ -92,7 +87,7 @@ Polymer({
* @private
*/
isTranslateDisabled_: function(languageCode, targetLanguageCode) {
- return this.languageHelper_.convertLanguageCodeForTranslate(languageCode) ==
+ return this.languageHelper.convertLanguageCodeForTranslate(languageCode) ==
targetLanguageCode;
},
@@ -151,9 +146,9 @@ Polymer({
*/
onTranslateEnabledChange_: function(e) {
if (e.target.checked)
- this.languageHelper_.enableTranslateLanguage(this.detail.language.code);
+ this.languageHelper.enableTranslateLanguage(this.detail.language.code);
else
- this.languageHelper_.disableTranslateLanguage(this.detail.language.code);
+ this.languageHelper.disableTranslateLanguage(this.detail.language.code);
},
/**
@@ -163,10 +158,10 @@ Polymer({
*/
onUILanguageChange_: function(e) {
if (e.target.checked) {
- this.languageHelper_.setUILanguage(this.detail.language.code);
+ this.languageHelper.setUILanguage(this.detail.language.code);
} else {
// Reset the chosen UI language to the actual UI language.
- this.languageHelper_.resetUILanguage();
+ this.languageHelper.resetUILanguage();
}
},

Powered by Google App Engine
This is Rietveld 408576698