Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Side by Side Diff: chrome/test/data/webui/settings/languages_page_browsertest.js

Issue 2252323002: MD Settings: reduce complexity and overhead of Languages singleton (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@RemoveLanguageInputMethods
Patch Set: Reduce diff Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** @fileoverview Suite of tests for settings-languages-page. */ 5 /** @fileoverview Suite of tests for settings-languages-page. */
6 6
7 /** @const {string} Path to root from chrome/test/data/webui/settings/. */ 7 /** @const {string} Path to root from chrome/test/data/webui/settings/. */
8 var ROOT_PATH = '../../../../../'; 8 var ROOT_PATH = '../../../../../';
9 9
10 // Polymer BrowserTest fixture. 10 // Polymer BrowserTest fixture.
11 GEN_INCLUDE( 11 GEN_INCLUDE(
12 [ROOT_PATH + 'chrome/test/data/webui/polymer_browser_test_base.js']); 12 [ROOT_PATH + 'chrome/test/data/webui/polymer_browser_test_base.js']);
13 // SettingsPageBrowserTest fixture. 13 // SettingsPageBrowserTest fixture.
14 GEN_INCLUDE([ROOT_PATH + 14 GEN_INCLUDE([ROOT_PATH +
15 'chrome/test/data/webui/settings/settings_page_browsertest.js']); 15 'chrome/test/data/webui/settings/settings_page_browsertest.js']);
16 16
17 var languageSettings = languageSettings || {};
18
19 /** 17 /**
20 * Test class for settings-languages-page UI. 18 * Test class for settings-languages-page UI.
21 * @constructor 19 * @constructor
22 * @extends {SettingsPageBrowserTest} 20 * @extends {SettingsPageBrowserTest}
23 */ 21 */
24 function SettingsLanguagesPageBrowserTest() {} 22 function SettingsLanguagesPageBrowserTest() {}
25 23
26 SettingsLanguagesPageBrowserTest.prototype = { 24 SettingsLanguagesPageBrowserTest.prototype = {
27 __proto__: SettingsPageBrowserTest.prototype, 25 __proto__: SettingsPageBrowserTest.prototype,
28 26
(...skipping 28 matching lines...) Expand all
57 var languageHelper; 55 var languageHelper;
58 suiteSetup(function() { 56 suiteSetup(function() {
59 advanced.set('pageVisibility.languages', true); 57 advanced.set('pageVisibility.languages', true);
60 Polymer.dom.flush(); 58 Polymer.dom.flush();
61 59
62 languagesSection = this.getSection(advanced, 'languages'); 60 languagesSection = this.getSection(advanced, 'languages');
63 assertTrue(!!languagesSection); 61 assertTrue(!!languagesSection);
64 languagesPage = languagesSection.querySelector('settings-languages-page'); 62 languagesPage = languagesSection.querySelector('settings-languages-page');
65 assertTrue(!!languagesPage); 63 assertTrue(!!languagesPage);
66 64
67 languageHelper = LanguageHelperImpl.getInstance(); 65 languageHelper = languagesPage.languageHelper;
68 return languageHelper.whenReady(); 66 return languageHelper.whenReady();
69 }.bind(this)); 67 }.bind(this));
70 68
71 teardown(function(done) { 69 teardown(function(done) {
72 // Close the section if we're in a sub-page. 70 // Close the section if we're in a sub-page.
73 if (settings.getCurrentRoute().isSubpage()) { 71 if (settings.getCurrentRoute().isSubpage()) {
74 settings.navigateTo(settings.Route.ADVANCED); 72 settings.navigateTo(settings.Route.ADVANCED);
75 setTimeout(done); 73 setTimeout(done);
76 } else { 74 } else {
77 done(); 75 done();
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 assertTrue(!!languagesPage.$$('settings-edit-dictionary-page')); 135 assertTrue(!!languagesPage.$$('settings-edit-dictionary-page'));
138 } 136 }
139 }); 137 });
140 }.bind(this)); 138 }.bind(this));
141 139
142 // TODO(michaelpg): Test more aspects of the languages UI. 140 // TODO(michaelpg): Test more aspects of the languages UI.
143 141
144 // Run all registered tests. 142 // Run all registered tests.
145 mocha.run(); 143 mocha.run();
146 }); 144 });
OLDNEW
« no previous file with comments | « chrome/test/data/webui/settings/cr_settings_browsertest.js ('k') | chrome/test/data/webui/settings/languages_page_tests.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698