Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Side by Side Diff: chrome/browser/resources/settings/languages_page/manage_languages_page.html

Issue 2252323002: MD Settings: reduce complexity and overhead of Languages singleton (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@RemoveLanguageInputMethods
Patch Set: Reduce diff Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/cr_elements/icons.html"> 1 <link rel="import" href="chrome://resources/cr_elements/icons.html">
2 <link rel="import" href="chrome://resources/html/assert.html"> 2 <link rel="import" href="chrome://resources/html/assert.html">
3 <link rel="import" href="chrome://resources/html/cr.html"> 3 <link rel="import" href="chrome://resources/html/cr.html">
4 <link rel="import" href="chrome://resources/html/polymer.html"> 4 <link rel="import" href="chrome://resources/html/polymer.html">
5 <link rel="import" href="chrome://resources/polymer/v1_0/iron-list/iron-list.htm l"> 5 <link rel="import" href="chrome://resources/polymer/v1_0/iron-list/iron-list.htm l">
6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-ch eckbox.html"> 6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-ch eckbox.html">
7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> 7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
8 <link rel="import" href="/settings_shared_css.html"> 8 <link rel="import" href="/settings_shared_css.html">
9 <link rel="import" href="languages.html"> 9 <link rel="import" href="languages.html">
10 10
11 <dom-module id="settings-manage-languages-page"> 11 <dom-module id="settings-manage-languages-page">
12 <template> 12 <template>
13 <style include="settings-shared"> 13 <style include="settings-shared">
14 .list-frame { 14 .list-frame {
15 align-items: initial; 15 align-items: initial;
16 display: flex; 16 display: flex;
17 flex-direction: column; 17 flex-direction: column;
18 } 18 }
19 19
20 iron-list { 20 iron-list {
21 height: 300px; 21 height: 300px;
22 } 22 }
23 23
24 .ripple-padding { 24 .ripple-padding {
25 /* Create a little extra space for checkbox ink ripple to flow into. */ 25 /* Create a little extra space for checkbox ink ripple to flow into. */
26 left: -20px; 26 left: -20px;
27 padding-left: 20px; 27 padding-left: 20px;
28 } 28 }
29 </style> 29 </style>
30 <settings-languages languages="{{languages}}"></settings-languages>
31 <div class="settings-box first block"> 30 <div class="settings-box first block">
32 <h2>$i18n{enabledLanguages}</h2> 31 <h2>$i18n{enabledLanguages}</h2>
33 <div class="list-frame vertical-list"> 32 <div class="list-frame vertical-list">
34 <template is="dom-repeat" items="{{languages.enabled}}"> 33 <template is="dom-repeat" items="{{languages.enabled}}">
35 <div class="list-item"> 34 <div class="list-item">
36 <div class="start" title="[[item.language.nativeDisplayName]]"> 35 <div class="start" title="[[item.language.nativeDisplayName]]">
37 [[item.language.displayName]] 36 [[item.language.displayName]]
38 </div> 37 </div>
39 <paper-icon-button icon="cr:clear" 38 <paper-icon-button icon="cr:clear"
40 on-tap="onRemoveLanguageTap_" hidden$="[[!item.removable]]"> 39 on-tap="onRemoveLanguageTap_" hidden$="[[!item.removable]]">
(...skipping 14 matching lines...) Expand all
55 [[item.displayName]] 54 [[item.displayName]]
56 </paper-checkbox> 55 </paper-checkbox>
57 </div> 56 </div>
58 </template> 57 </template>
59 </iron-list> 58 </iron-list>
60 </div> 59 </div>
61 </div> 60 </div>
62 </template> 61 </template>
63 <script src="manage_languages_page.js"></script> 62 <script src="manage_languages_page.js"></script>
64 </dom-module> 63 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698