chrome/browser/resources/settings/languages_page/manage_input_methods_page.html - Issue 2252323002: MD Settings: reduce complexity and overhead of Languages singleton

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/settings/languages_page/manage_input_methods_page.html

Issue 2252323002: MD Settings: reduce complexity and overhead of Languages singleton (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@RemoveLanguageInputMethods

Patch Set: Reduce diff Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/settings/languages_page/languages_types.js ('k') | chrome/browser/resources/settings/languages_page/manage_input_methods_page.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <link rel="import" href="chrome://resources/html/assert.html">	1 <link rel="import" href="chrome://resources/html/assert.html">

2 <link rel="import" href="chrome://resources/html/cr.html">	2 <link rel="import" href="chrome://resources/html/cr.html">

3 <link rel="import" href="chrome://resources/html/polymer.html">	3 <link rel="import" href="chrome://resources/html/polymer.html">

4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-ch eckbox.html">	4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-checkbox/paper-ch eckbox.html">

5 <link rel="import" href="/settings_shared_css.html">	5 <link rel="import" href="/settings_shared_css.html">

6 <link rel="import" href="languages.html">	6 <link rel="import" href="languages.html">

7	7

8 <dom-module id="settings-manage-input-methods-page">	8 <dom-module id="settings-manage-input-methods-page">

9 <template>	9 <template>

10 <style include="settings-shared"></style>	10 <style include="settings-shared"></style>

11 <settings-languages languages="{{languages}}"></settings-languages>

12 <div class="settings-box first block">	11 <div class="settings-box first block">

13 <template is="dom-repeat" items="[[languageList_]]">	12 <template is="dom-repeat" items="[[languageList_]]">

14 <h2>[[item.language.displayName]]</h2>	13 <h2>[[item.language.displayName]]</h2>

15 <div class="list-frame vertical-list">	14 <div class="list-frame vertical-list">

16 <template is="dom-repeat" items="[[item.inputMethods]]">	15 <template is="dom-repeat" items="[[item.inputMethods]]">

17 <div class="list-item">	16 <div class="list-item">

18 <div class="language-name">	17 <div class="language-name">

19 <paper-checkbox checked="[[item.enabled]]"	18 <paper-checkbox checked="[[item.enabled]]"

20 on-change="onCheckboxChange_"	19 on-change="onCheckboxChange_"

21 disabled="[[!enableInputMethodCheckbox_(	20 disabled="[[!enableInputMethodCheckbox_(

22 item, languages.inputMethods.enabled.*)]]">	21 item, languages.inputMethods.enabled.*)]]">

23 <span>[[item.displayName]]</span>	22 <span>[[item.displayName]]</span>

24 </paper-checkbox>	23 </paper-checkbox>

25 </div>	24 </div>

26 </div>	25 </div>

27 </template>	26 </template>

28 </div>	27 </div>

29 </template>	28 </template>

30 </div>	29 </div>

31 </template>	30 </template>

32 <script src="manage_input_methods_page.js"></script>	31 <script src="manage_input_methods_page.js"></script>

33 </dom-module>	32 </dom-module>

OLD	NEW