Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Unified Diff: components/password_manager/core/browser/password_form_manager_unittest.cc

Issue 2252283005: Introduce password_manager::FormFetcher (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@621355_const_best_matches
Patch Set: Keep updating PasswordStore for blacklisting Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/password_manager/core/browser/password_form_manager.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/password_form_manager_unittest.cc
diff --git a/components/password_manager/core/browser/password_form_manager_unittest.cc b/components/password_manager/core/browser/password_form_manager_unittest.cc
index 7d9d72298f617f67c7a19e91c2802907cb3841f9..658e12fd4168d1d489d3898da4bc576d202b9d04 100644
--- a/components/password_manager/core/browser/password_form_manager_unittest.cc
+++ b/components/password_manager/core/browser/password_form_manager_unittest.cc
@@ -902,9 +902,9 @@ TEST_F(PasswordFormManagerTest, TestBlacklistMatching) {
result.push_back(base::MakeUnique<PasswordForm>(*saved_match()));
form_manager.OnGetPasswordStoreResults(std::move(result));
EXPECT_TRUE(form_manager.IsBlacklisted());
- EXPECT_THAT(
- form_manager.blacklisted_matches(),
- ElementsAre(Pointee(blacklisted_match), Pointee(blacklisted_match2)));
+ EXPECT_THAT(form_manager.blacklisted_matches(),
+ UnorderedElementsAre(Pointee(blacklisted_match),
+ Pointee(blacklisted_match2)));
EXPECT_EQ(1u, form_manager.best_matches().size());
EXPECT_EQ(*saved_match(), *form_manager.preferred_match());
}
@@ -2578,7 +2578,7 @@ TEST_F(PasswordFormManagerTest, FetchStatistics) {
form_manager()->FetchDataFromPasswordStore();
base::RunLoop().RunUntilIdle();
- EXPECT_THAT(form_manager()->interactions_stats(),
+ EXPECT_THAT(form_manager()->form_fetcher()->GetInteractionsStats(),
ElementsAre(Pointee(stats)));
}
#else
@@ -2944,8 +2944,9 @@ TEST_F(PasswordFormManagerTest, FederatedCredentialsFiltered) {
results.push_back(base::MakeUnique<PasswordForm>(*saved_match()));
form_manager()->OnGetPasswordStoreResults(std::move(results));
- EXPECT_EQ(1u, form_manager()->federated_matches().size());
- EXPECT_EQ(*form_manager()->federated_matches()[0], federated);
+ EXPECT_EQ(1u, form_manager()->form_fetcher()->GetFederatedMatches().size());
+ EXPECT_EQ(*form_manager()->form_fetcher()->GetFederatedMatches()[0],
+ federated);
EXPECT_EQ(1u, form_manager()->best_matches().size());
EXPECT_EQ(*(form_manager()->best_matches().begin()->second), *saved_match());
}
« no previous file with comments | « components/password_manager/core/browser/password_form_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698