components/password_manager/core/browser/BUILD.gn - Issue 2252283005: Introduce password_manager::FormFetcher

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/BUILD.gn

Issue 2252283005: Introduce password_manager::FormFetcher (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@621355_const_best_matches

Patch Set: Keep updating PasswordStore for blacklisting Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/content/browser/credential_manager_impl.cc ('k') | components/password_manager/core/browser/form_fetcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/BUILD.gn

diff --git a/components/password_manager/core/browser/BUILD.gn b/components/password_manager/core/browser/BUILD.gn

index 16e9a2d2f41809d108d866737dfd8064174d6e52..2e551815d18c461af4f3d94ca2251b49e6d9b979 100644

--- a/components/password_manager/core/browser/BUILD.gn

+++ b/components/password_manager/core/browser/BUILD.gn

@@ -44,6 +44,9 @@ static_library("browser") {

"facet_manager.cc",

"facet_manager.h",

"facet_manager_host.h",

+ "form_fetcher.h",

+ "form_fetcher_impl.cc",

+ "form_fetcher_impl.h",

"form_saver.h",

"form_saver_impl.cc",

"form_saver_impl.h",

@@ -253,6 +256,7 @@ source_set("unit_tests") {

"export/password_csv_writer_unittest.cc",

"export/password_exporter_unittest.cc",

"facet_manager_unittest.cc",

+ "form_fetcher_impl_unittest.cc",

"form_saver_impl_unittest.cc",

"import/csv_reader_unittest.cc",

"import/password_csv_reader_unittest.cc",