chrome/browser/ui/passwords/manage_passwords_state_unittest.cc - Issue 2252283005: Introduce password_manager::FormFetcher

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_state_unittest.cc

Issue 2252283005: Introduce password_manager::FormFetcher (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@621355_const_best_matches

Patch Set: Keep updating PasswordStore for blacklisting Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_state.cc ('k') | chrome/browser/ui/passwords/manage_passwords_ui_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_state_unittest.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_state_unittest.cc b/chrome/browser/ui/passwords/manage_passwords_state_unittest.cc

index b927f5494f3288046dc2b3e0c0bb4fde31bf0959..22f1bc4605bc24d2e0e1524ff1267525850327a5 100644

--- a/chrome/browser/ui/passwords/manage_passwords_state_unittest.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_state_unittest.cc

@@ -138,10 +138,11 @@ ManagePasswordsStateTest::CreateFormManagerInternal(bool include_federated) {

}

test_form_manager->OnGetPasswordStoreResults(std::move(test_stored_forms_));

EXPECT_EQ(include_federated ? 1u : 0u,

- test_form_manager->federated_matches().size());

+ test_form_manager->form_fetcher()->GetFederatedMatches().size());

if (include_federated) {

- EXPECT_EQ(test_local_federated_form(),

- *test_form_manager->federated_matches().front());

+ EXPECT_EQ(

+ test_local_federated_form(),

+ *test_form_manager->form_fetcher()->GetFederatedMatches().front());

}

return test_form_manager;

}