[turbofan] Allow for 32-bit field offsets in store elimination.

[turbofan] Allow for 32-bit field offsets in store elimination.

R=jarin
BUG=chromium:637121
Committed: https://crrev.com/78613430850068a2d7208cc63df8dad0bb21c893
Cr-Commit-Position: refs/heads/master@{#38899}

[bgeron, 2016-08-19 09:21:40]

The CQ bit was checked by bgeron@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-19 09:21:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bgeron, 2016-08-19 09:23:22]

Description was changed from

==========
[turbofan] Allow for 32-bit field offsets in store elimination.

R=jarin
BUG=
==========

to

==========
[turbofan] Allow for 32-bit field offsets in store elimination.

R=jarin
BUG=chromium:637121
==========

[bgeron, 2016-08-19 09:24:10]

PTAL.

[Jarin, 2016-08-19 09:30:35]

https://codereview.chromium.org/2252283004/diff/1/src/compiler/store-store-el...
File src/compiler/store-store-elimination.cc (right):

https://codereview.chromium.org/2252283004/diff/1/src/compiler/store-store-el...
src/compiler/store-store-elimination.cc:75: // 4GiB ought to be enough for
anybody.
Just remove the comment.

https://codereview.chromium.org/2252283004/diff/1/src/compiler/store-store-el...
src/compiler/store-store-elimination.cc:176: CHECK(0 <= offset &&
(int64_t)offset < (1ll << 8 * sizeof(StoreOffset)));
At this point, the upper bound check is useless, just remove it.

https://codereview.chromium.org/2252283004/diff/1/src/compiler/store-store-el...
src/compiler/store-store-elimination.cc:177: return (StoreOffset)offset;
static_cast, please.

[commit-bot: I haz the power, 2016-08-19 10:00:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-19 10:00:38]

Dry run: This issue passed the CQ dry run.

[bgeron, 2016-08-19 10:42:10]

https://codereview.chromium.org/2252283004/diff/1/src/compiler/store-store-el...
File src/compiler/store-store-elimination.cc (right):

https://codereview.chromium.org/2252283004/diff/1/src/compiler/store-store-el...
src/compiler/store-store-elimination.cc:75: // 4GiB ought to be enough for
anybody.
On 2016/08/19 09:30:35, Jarin wrote:
> Just remove the comment.

Done.

https://codereview.chromium.org/2252283004/diff/1/src/compiler/store-store-el...
src/compiler/store-store-elimination.cc:176: CHECK(0 <= offset &&
(int64_t)offset < (1ll << 8 * sizeof(StoreOffset)));
On 2016/08/19 09:30:35, Jarin wrote:
> At this point, the upper bound check is useless, just remove it.

Done.

https://codereview.chromium.org/2252283004/diff/1/src/compiler/store-store-el...
src/compiler/store-store-elimination.cc:177: return (StoreOffset)offset;
On 2016/08/19 09:30:35, Jarin wrote:
> static_cast, please.

Done.

[Jarin, 2016-08-22 07:43:30]

lgtm

[bgeron, 2016-08-25 11:06:37]

The CQ bit was checked by bgeron@google.com

[commit-bot: I haz the power, 2016-08-25 11:06:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 11:27:42]

Description was changed from

==========
[turbofan] Allow for 32-bit field offsets in store elimination.

R=jarin
BUG=chromium:637121
==========

to

==========
[turbofan] Allow for 32-bit field offsets in store elimination.

R=jarin
BUG=chromium:637121
==========

[commit-bot: I haz the power, 2016-08-25 11:27:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-25 11:28:05]

Description was changed from

==========
[turbofan] Allow for 32-bit field offsets in store elimination.

R=jarin
BUG=chromium:637121
==========

to

==========
[turbofan] Allow for 32-bit field offsets in store elimination.

R=jarin
BUG=chromium:637121

Committed: https://crrev.com/78613430850068a2d7208cc63df8dad0bb21c893
Cr-Commit-Position: refs/heads/master@{#38899}
==========

[commit-bot: I haz the power, 2016-08-25 11:28:05]

Patchset 2 (id:??) landed as
https://crrev.com/78613430850068a2d7208cc63df8dad0bb21c893
Cr-Commit-Position: refs/heads/master@{#38899}