Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 2252273002: Removed Instructions object from Observatory models (Closed)

Created:
4 years, 4 months ago by cbernaschina
Modified:
4 years, 4 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Removed Instructions object from Observatory models Committed: https://github.com/dart-lang/sdk/commit/0b4fe4825f20b8ca1d3539af8513d12e4bf03ef3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -243 lines) Patch
M runtime/observatory/lib/elements.dart View 4 chunks +0 lines, -4 lines 0 comments Download
M runtime/observatory/lib/elements.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/models.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/helpers/any_ref.dart View 2 chunks +0 lines, -3 lines 0 comments Download
D runtime/observatory/lib/src/elements/instructions_ref.dart View 1 chunk +0 lines, -62 lines 0 comments Download
D runtime/observatory/lib/src/elements/instructions_view.dart View 1 chunk +0 lines, -21 lines 0 comments Download
D runtime/observatory/lib/src/elements/instructions_view.html View 1 chunk +0 lines, -46 lines 0 comments Download
M runtime/observatory/lib/src/elements/service_view.dart View 1 chunk +0 lines, -5 lines 0 comments Download
D runtime/observatory/lib/src/models/objects/instructions.dart View 1 chunk +0 lines, -9 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 2 chunks +0 lines, -23 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
D runtime/observatory/tests/observatory_ui/instructions_ref/element_test.dart View 1 chunk +0 lines, -30 lines 0 comments Download
D runtime/observatory/tests/observatory_ui/instructions_ref/element_test.html View 1 chunk +0 lines, -20 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks.dart View 1 chunk +0 lines, -1 line 0 comments Download
D runtime/observatory/tests/observatory_ui/mocks/objects/instructions.dart View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
cbernaschina
4 years, 4 months ago (2016-08-18 00:56:21 UTC) #2
cbernaschina
Committed patchset #1 (id:1) manually as 0b4fe4825f20b8ca1d3539af8513d12e4bf03ef3 (presubmit successful).
4 years, 4 months ago (2016-08-18 01:51:27 UTC) #5
rmacnak
4 years, 4 months ago (2016-08-18 17:34:18 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698