chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc - Issue 2252263002: Disable flaky test TestClickingOnOverflowedAction on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc

Issue 2252263002: Disable flaky test TestClickingOnOverflowedAction on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Disable flaky test TestClickingOnOverflowedAction on Windows Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc

diff --git a/chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc b/chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc

index 32ca813b49389f6febabb09318778f3b8d34da35..179d2576c05a41bb36b793999465574f61696641 100644

--- a/chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc

+++ b/chrome/browser/ui/views/toolbar/toolbar_action_view_interactive_uitest.cc

@@ -169,8 +169,9 @@ void ToolbarActionViewInteractiveUITest::TearDownOnMainThread() {

ToolbarActionsBar::disable_animations_for_testing_ = false;

}

-#if defined(USE_OZONE)

+#if defined(USE_OZONE) || defined(OS_WIN)

// ozone bringup - http://crbug.com/401304

+// flaky on Windows - http://crbug.com/638692

#define MAYBE_TestClickingOnOverflowedAction DISABLED_TestClickingOnOverflowedAction

#else

#define MAYBE_TestClickingOnOverflowedAction TestClickingOnOverflowedAction

« no previous file with comments | « no previous file | no next file » | no next file with comments »