Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2252233002: Make downloads_api functions synchronous (Closed)

Created:
4 years, 4 months ago by Lof
Modified:
4 years, 4 months ago
Reviewers:
benjhayden
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make downloads_api functions synchronous Async functions without SendResult look incorrect. Made them synchronous and wrote tests. BUG=638754 R=benjhayden@chromium.org Committed: https://crrev.com/4b54851675b93b91ab49f0581e616bd4804ff2af Cr-Commit-Position: refs/heads/master@{#412854}

Patch Set 1 #

Patch Set 2 : disable tests on chrome os #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -9 lines) Patch
M chrome/browser/extensions/api/downloads/downloads_api.h View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc View 1 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Lof
4 years, 4 months ago (2016-08-17 22:27:15 UTC) #1
benjhayden
lgtm
4 years, 4 months ago (2016-08-17 22:47:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2252233002/1
4 years, 4 months ago (2016-08-18 06:14:47 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/263277)
4 years, 4 months ago (2016-08-18 07:13:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2252233002/20001
4 years, 4 months ago (2016-08-18 08:32:52 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/220563)
4 years, 4 months ago (2016-08-18 09:11:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2252233002/20001
4 years, 4 months ago (2016-08-18 16:24:13 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-18 16:40:36 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 16:43:24 UTC) #16
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/4b54851675b93b91ab49f0581e616bd4804ff2af
Cr-Commit-Position: refs/heads/master@{#412854}

Powered by Google App Engine
This is Rietveld 408576698