Fix calling object methods and properties on function types

Fix calling object methods and properties on function types

Fixes https://github.com/dart-lang/sdk/issues/27097 .
BUG=
R=brianwilkerson@google.com, jmesserly@google.com

Committed: https://github.com/dart-lang/sdk/commit/1c81fe712695d68ca55123df638d84b70336c115

[Leaf, 2016-08-17 21:00:39]

Description was changed from

==========
Fix calling object methods and properties on function types

BUG=
==========

to

==========
Fix calling object methods and properties on function types

Fixes https://github.com/dart-lang/sdk/issues/27097 .
BUG=
==========

[Leaf, 2016-08-17 21:06:29]

leafp@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2016-08-17 21:24:15]

lgtm

https://codereview.chromium.org/2252183002/diff/20001/pkg/analyzer/lib/src/ge...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/2252183002/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/resolver.dart:9633: bool
isObjectProperty(SimpleIdentifier id);
I think the analyzer code is generally fairly consistent about using 'property'
to mean 'getter' or 'setter' and 'member' to mean 'property' or 'method'.

https://codereview.chromium.org/2252183002/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/resolver.dart:9641: InterfaceType get boolType;
Should this just implement TypeProvider (rather than duplicate these
declarations)?

[Jennifer Messerly, 2016-08-17 21:26:24]

jmesserly@google.com changed reviewers:
+ jmesserly@google.com

[Jennifer Messerly, 2016-08-17 21:26:24]

lgtm to me too, a couple of comments on top of Brian's

https://codereview.chromium.org/2252183002/diff/20001/pkg/analyzer/lib/src/ge...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/2252183002/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/resolver.dart:9621: bool
isObjectGetter(SimpleIdentifier id);
maybe pass in the String name here? it seems like "id.name" is all we use

https://codereview.chromium.org/2252183002/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/resolver.dart:9638: * implementations
nit: should end with period

https://codereview.chromium.org/2252183002/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/resolver.dart:9677: with TypeProviderBaseMixin
in current Dart, this is equivalent to "extends TypeProviderBaseMixin"

... that said whether y'all on the language team will change it, I'm not sure :)

[Leaf, 2016-08-17 22:07:05]

https://codereview.chromium.org/2252183002/diff/20001/pkg/analyzer/lib/src/ge...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/2252183002/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/resolver.dart:9621: bool
isObjectGetter(SimpleIdentifier id);
On 2016/08/17 21:26:24, John Messerly wrote:
> maybe pass in the String name here? it seems like "id.name" is all we use

Done.

https://codereview.chromium.org/2252183002/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/resolver.dart:9633: bool
isObjectProperty(SimpleIdentifier id);
On 2016/08/17 21:24:15, Brian Wilkerson wrote:
> I think the analyzer code is generally fairly consistent about using
'property'
> to mean 'getter' or 'setter' and 'member' to mean 'property' or 'method'.

Done.

https://codereview.chromium.org/2252183002/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/resolver.dart:9638: * implementations
On 2016/08/17 21:26:24, John Messerly wrote:
> nit: should end with period

Done.

https://codereview.chromium.org/2252183002/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/resolver.dart:9641: InterfaceType get boolType;
On 2016/08/17 21:24:15, Brian Wilkerson wrote:
> Should this just implement TypeProvider (rather than duplicate these
> declarations)?

Nice.  Didn't realize you could do this, much better.

https://codereview.chromium.org/2252183002/diff/20001/pkg/analyzer/lib/src/ge...
pkg/analyzer/lib/src/generated/resolver.dart:9677: with TypeProviderBaseMixin
On 2016/08/17 21:26:24, John Messerly wrote:
> in current Dart, this is equivalent to "extends TypeProviderBaseMixin"
> 
> ... that said whether y'all on the language team will change it, I'm not sure
:)

Done.

[Leaf, 2016-08-17 22:24:11]

Description was changed from

==========
Fix calling object methods and properties on function types

Fixes https://github.com/dart-lang/sdk/issues/27097 .
BUG=
==========

to

==========
Fix calling object methods and properties on function types

Fixes https://github.com/dart-lang/sdk/issues/27097 .
BUG=
R=brianwilkerson@google.com, jmesserly@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1c81fe712695d68ca55123df638d84b70336c115
==========

[Leaf, 2016-08-17 22:24:13]

Committed patchset #4 (id:60001) manually as
1c81fe712695d68ca55123df638d84b70336c115 (presubmit successful).