Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 2252173002: Make EnterpriseInstallAttributes::GetRegistrationUser() private. (Closed)

Created:
4 years, 4 months ago by Thiemo Nagel
Modified:
4 years, 4 months ago
Reviewers:
pastarmovj
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make EnterpriseInstallAttributes::GetRegistrationUser() private. In the long run, it should probably be removed. BUG=638713 Committed: https://crrev.com/0c08e95b4d061021f5ecee2a38465aa238c93d2f Cr-Commit-Position: refs/heads/master@{#412797}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
M chrome/browser/chromeos/policy/enterprise_install_attributes.h View 3 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/policy/enterprise_install_attributes.cc View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
Thiemo Nagel
Hi Julian, I'm sure you have fond memories of EnterpriseInstallAttributes. ;) Could you please take ...
4 years, 4 months ago (2016-08-17 20:30:12 UTC) #5
pastarmovj
LGTM I think this used to be used for prepopulating the enrollment user in some ...
4 years, 4 months ago (2016-08-18 08:29:38 UTC) #8
Thiemo Nagel
On 2016/08/18 08:29:38, pastarmovj wrote: > LGTM > > I think this used to be ...
4 years, 4 months ago (2016-08-18 10:56:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2252173002/1
4 years, 4 months ago (2016-08-18 10:56:59 UTC) #11
commit-bot: I haz the power
Internal error: failed to checkout. Please try again.
4 years, 4 months ago (2016-08-18 11:03:54 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2252173002/1
4 years, 4 months ago (2016-08-18 11:23:53 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-18 12:04:19 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 12:06:15 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0c08e95b4d061021f5ecee2a38465aa238c93d2f
Cr-Commit-Position: refs/heads/master@{#412797}

Powered by Google App Engine
This is Rietveld 408576698