Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: gpu/command_buffer/client/gles2_implementation_unittest.cc

Issue 2252163003: Update Context Client Visibility to use Scoped Pattern (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: feedback Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/client/gles2_implementation_unittest.cc
diff --git a/gpu/command_buffer/client/gles2_implementation_unittest.cc b/gpu/command_buffer/client/gles2_implementation_unittest.cc
index 8e532dc4c430be8cc75fd9513fae23302e99ed41..63b175f6d80d07a90b29133a15905013253e263d 100644
--- a/gpu/command_buffer/client/gles2_implementation_unittest.cc
+++ b/gpu/command_buffer/client/gles2_implementation_unittest.cc
@@ -17,6 +17,7 @@
#include <memory>
#include "base/compiler_specific.h"
+#include "base/memory/ptr_util.h"
#include "gpu/command_buffer/client/client_test_helper.h"
#include "gpu/command_buffer/client/gles2_cmd_helper.h"
#include "gpu/command_buffer/client/program_info_manager.h"
@@ -4609,17 +4610,21 @@ TEST_F(GLES2ImplementationManualInitTest, FailInitOnTransferBufferFail) {
TEST_F(GLES2ImplementationTest, ClientVisibility) {
EXPECT_FALSE(gl_->AnyClientsVisible());
- gl_->SetClientVisible(0, true);
- EXPECT_TRUE(gl_->AnyClientsVisible());
- gl_->SetClientVisible(0, false);
- EXPECT_FALSE(gl_->AnyClientsVisible());
- gl_->SetClientVisible(0, true);
- gl_->SetClientVisible(1, true);
- EXPECT_TRUE(gl_->AnyClientsVisible());
- gl_->SetClientVisible(0, false);
- EXPECT_TRUE(gl_->AnyClientsVisible());
- gl_->SetClientVisible(1, false);
- EXPECT_FALSE(gl_->AnyClientsVisible());
+ {
+ auto visibility_0 = gl_->ClientBecameVisible();
+ EXPECT_TRUE(gl_->AnyClientsVisible());
+ gl_->ClientBecameNotVisible(std::move(visibility_0));
+ EXPECT_FALSE(gl_->AnyClientsVisible());
+ }
+ {
+ auto visibility_0 = gl_->ClientBecameVisible();
+ auto visibility_1 = gl_->ClientBecameVisible();
+ EXPECT_TRUE(gl_->AnyClientsVisible());
+ gl_->ClientBecameNotVisible(std::move(visibility_0));
+ EXPECT_TRUE(gl_->AnyClientsVisible());
+ gl_->ClientBecameNotVisible(std::move(visibility_1));
+ EXPECT_FALSE(gl_->AnyClientsVisible());
+ }
}
#include "base/macros.h"

Powered by Google App Engine
This is Rietveld 408576698