Update Context Client Visibility to use Scoped Pattern

cc/test/test_context_support.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/test/test_context_support.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include "base/bind.h"
 #include "base/location.h"
+#include "base/memory/ptr_util.h"
 #include "base/single_thread_task_runner.h"
 #include "base/threading/thread_task_runner_handle.h"
+#include "gpu/command_buffer/client/scoped_visibility_impl.h"
 
 namespace cc {
 
 TestContextSupport::TestContextSupport()
-    : out_of_order_callbacks_(false), weak_ptr_factory_(this) {}
+    : out_of_order_callbacks_(false),
+      visible_clients_(0),
+      weak_ptr_factory_(this) {}
 
 TestContextSupport::~TestContextSupport() {}
 
 void TestContextSupport::SignalSyncToken(const gpu::SyncToken& sync_token,
                                          const base::Closure& callback) {
   sync_point_callbacks_.push_back(callback);
   base::ThreadTaskRunnerHandle::Get()->PostTask(
       FROM_HERE, base::Bind(&TestContextSupport::CallAllSyncPointCallbacks,
                             weak_ptr_factory_.GetWeakPtr()));
 }
@@ skipping 55 matching lines @@
 }
 
 uint64_t TestContextSupport::ShareGroupTracingGUID() const {
   NOTIMPLEMENTED();
   return 0;
 }
 
 void TestContextSupport::SetErrorMessageCallback(
     const base::Callback<void(const char*, int32_t)>& callback) {}
 
-void TestContextSupport::SetClientVisible(int client_id, bool is_visible) {
-  if (is_visible) {
-    visible_clients_.insert(client_id);
-  } else {
-    auto found = visible_clients_.find(client_id);
-    if (found != visible_clients_.end())
-      visible_clients_.erase(found);
-  }
+std::unique_ptr<gpu::ContextSupport::ScopedVisibility>
+TestContextSupport::ClientBecameVisible() {
+  ++visible_clients_;
+  return std::unique_ptr<gpu::ScopedVisibilityImpl>(

[danakj, 2016/08/18 21:39:44]

I think you can just write your own impl here, I don't like deping on impls from
other places. It can just be local to this .cc file. That or move the class out
of ContextSupport and just make it a direct thing no subclassing.

also return base::MakeUnique<T>(..);

[ericrk, 2016/08/19 17:23:19]

makes sense, moved to cc file

+      new gpu::ScopedVisibilityImpl(this));
+}
+
+void TestContextSupport::ClientBecameNotVisible(
+    std::unique_ptr<ScopedVisibility> visibility) {
+  DCHECK_GT(visible_clients_, 0u);
+  --visible_clients_;
+  static_cast<gpu::ScopedVisibilityImpl*>(visibility.get())->Release(this);
 }
 
 bool TestContextSupport::AnyClientsVisible() const {
-  return !visible_clients_.empty();
+  return visible_clients_ > 0;
 }
 
 }  // namespace cc