Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 2252163002: Attempt to rebaseline remaining crbug.com/463358 tests (Closed)

Created:
4 years, 4 months ago by Stephen Chennney
Modified:
4 years, 4 months ago
Reviewers:
f(malita)
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Attempt to rebaseline remaining crbug.com/463358 tests There are 2 tests remaining marked for crbug.com/463358. They both look like they need rebaselines, and maybe they are now fixed and stable. There is still some chance that the Linux Debug result for fast/transforms/transformed-caret.html is broken or flakey, and will need to be re-added after the rebaseline. No test should really be marked under this bug. It relates to a clang roll that was itself reverted, so the cause of the failures no longer exists. TBR=fmalita@chromium.org BUG=463358, 636475 Committed: https://crrev.com/246cf98c2d65b307d0219893f80b0f47e3146d30 Cr-Commit-Position: refs/heads/master@{#412881}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2252163002/1
4 years, 4 months ago (2016-08-17 19:27:14 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/281816)
4 years, 4 months ago (2016-08-17 20:46:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2252163002/20001
4 years, 4 months ago (2016-08-18 16:15:46 UTC) #8
f(malita)
lgtm
4 years, 4 months ago (2016-08-18 17:05:45 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-18 17:42:25 UTC) #11
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 17:44:12 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/246cf98c2d65b307d0219893f80b0f47e3146d30
Cr-Commit-Position: refs/heads/master@{#412881}

Powered by Google App Engine
This is Rietveld 408576698