Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2252143002: Fix fb variable name in GLSL (Closed)

Created:
4 years, 4 months ago by egdaniel
Modified:
4 years, 4 months ago
CC:
reviews_skia.org, robertphillips
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix fb variable name in GLSL BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2252143002 NOTREECHECKS=True Committed: https://skia.googlesource.com/skia/+/bd4121ab24f16f0ddaef4701e3636eae94d2c301

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/gpu/glsl/GrGLSLFragmentShaderBuilder.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
egdaniel
This should fix the broken GMs on gold
4 years, 4 months ago (2016-08-17 18:54:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2252143002/1
4 years, 4 months ago (2016-08-17 18:54:40 UTC) #5
robertphillips
lgtm
4 years, 4 months ago (2016-08-17 18:55:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2252143002/1
4 years, 4 months ago (2016-08-17 19:54:17 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 19:55:33 UTC) #14
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/bd4121ab24f16f0ddaef4701e3636eae94d2c301

Powered by Google App Engine
This is Rietveld 408576698