ui/gfx: Add Android support for gfx_unittests target.

ui/gfx: Add Android support for gfx_unittests target.

By using gtest_target_type we can specialize gfx_unittests for android
and thus get it running on Android.

BUG=331829, 299841
TEST=gfx_unittests_apk
R=danakj@chromium.org,bulach@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261986

[tfarina, 2014-04-04 03:22:38]

Dana, could you review ui/gfx/ and build/all.gyp to me?

Looks like Marcus is out until April 14. Aurimas, may you review this for
Android correctness in his absense?

Mike, fyi.

Thanks all!

[danakj, 2014-04-04 14:34:37]

LGTM

https://codereview.chromium.org/225213002/diff/1/ui/gfx/gfx.gyp
File ui/gfx/gfx.gyp (right):

https://codereview.chromium.org/225213002/diff/1/ui/gfx/gfx.gyp#newcode543
ui/gfx/gfx.gyp:543: # ui_unittests into an android apk for execution.
gfx_unittests

[aurimas (slooooooooow), 2014-04-04 18:09:26]

+cjhopman who knows more about Android gyp.

[cjhopman, 2014-04-04 18:14:25]

https://codereview.chromium.org/225213002/diff/1/ui/gfx/gfx.gyp
File ui/gfx/gfx.gyp (right):

https://codereview.chromium.org/225213002/diff/1/ui/gfx/gfx.gyp#newcode555
ui/gfx/gfx.gyp:555: 'input_shlib_path':
'<(SHARED_LIB_DIR)/<(SHARED_LIB_PREFIX)gfx_unittests<(SHARED_LIB_SUFFIX)',
nit: input_shlib_path isn't needed

(it appears in all the other similar targets but it doesn't actually do
anything)

[cjhopman, 2014-04-04 18:14:29]

lgtm

[tfarina, 2014-04-05 00:12:36]

https://codereview.chromium.org/225213002/diff/1/ui/gfx/gfx.gyp
File ui/gfx/gfx.gyp (right):

https://codereview.chromium.org/225213002/diff/1/ui/gfx/gfx.gyp#newcode543
ui/gfx/gfx.gyp:543: # ui_unittests into an android apk for execution.
On 2014/04/04 14:34:37, danakj wrote:
> gfx_unittests

Done.

https://codereview.chromium.org/225213002/diff/1/ui/gfx/gfx.gyp#newcode555
ui/gfx/gfx.gyp:555: 'input_shlib_path':
'<(SHARED_LIB_DIR)/<(SHARED_LIB_PREFIX)gfx_unittests<(SHARED_LIB_SUFFIX)',
On 2014/04/04 18:14:25, cjhopman wrote:
> nit: input_shlib_path isn't needed
> 
> (it appears in all the other similar targets but it doesn't actually do
> anything)

Done.

[tfarina, 2014-04-05 00:12:41]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2014-04-05 00:12:41]

The CQ bit was unchecked by tfarina@chromium.org

[tfarina, 2014-04-05 00:12:41]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-04-05 00:12:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/225213002/20001

[commit-bot: I haz the power, 2014-04-05 00:51:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-05 00:51:01]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_compile_dbg

[tfarina, 2014-04-05 01:04:30]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2014-04-05 01:04:30]

The CQ bit was unchecked by tfarina@chromium.org

[tfarina, 2014-04-05 01:04:31]

The CQ bit was unchecked by tfarina@chromium.org

[tfarina, 2014-04-05 01:04:31]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2014-04-05 01:04:31]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2014-04-05 01:55:42]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-04-05 01:55:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/225213002/20001

[commit-bot: I haz the power, 2014-04-05 07:45:40]

Change committed as 261986