Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6655)

Unified Diff: chrome/android/java/AndroidManifest.xml

Issue 2252103002: Introduce ChromeVR to Chrome on Android (behind a build flag) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address more reviews Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/AndroidManifest.xml
diff --git a/chrome/android/java/AndroidManifest.xml b/chrome/android/java/AndroidManifest.xml
index ea8d11b72dad08a24ecf47303ebcab817af0b8b9..787618234473fe2a7f016ac0278e813809f4d52c 100644
--- a/chrome/android/java/AndroidManifest.xml
+++ b/chrome/android/java/AndroidManifest.xml
@@ -52,6 +52,11 @@ by a child template that "extends" this file.
<uses-permission android:name="android.permission.WAKE_LOCK"/>
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE"/>
<uses-permission android:name="android.permission.WRITE_SYNC_SETTINGS"/>
+ {% set enable_vr_shell = enable_vr_shell|default(0) %}
+ {% if enable_vr_shell == "true" %}
+ <!-- Required to read the paired viewer's distortion parameters. -->
+ <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE"/>
+ {% endif %}
<permission android:name="{{ manifest_package }}.permission.CHILD_SERVICE" android:protectionLevel="signature" />
<permission android:name="{{ manifest_package }}.permission.READ_WRITE_BOOKMARK_FOLDERS" android:protectionLevel="signatureOrSystem" />
@@ -156,11 +161,6 @@ by a child template that "extends" this file.
{% if channel in ['dev', 'canary', 'default'] %}
<category android:name="android.intent.category.MULTIWINDOW_LAUNCHER" />
{% endif %}
- {% set enable_vr_shell = enable_vr_shell|default(0) %}
- {% if enable_vr_shell == "true" %}
- <!-- Show icon in Daydream app launcher. -->
- <category android:name="com.google.intent.category.DAYDREAM" />
- {% endif %}
</intent-filter>
<!-- Matches the common case of intents with no MIME type.
Make sure to keep in sync with the next filter. -->
@@ -345,6 +345,22 @@ by a child template that "extends" this file.
android:configChanges="orientation|keyboardHidden|keyboard|screenSize|mcc|mnc|screenLayout|smallestScreenSize"
android:hardwareAccelerated="false">
</activity>
+ {% if enable_vr_shell == "true" %}
+ <activity android:name="org.chromium.chrome.browser.VrActivity"
+ android:theme="@style/TabbedModeTheme"
Maria 2016/08/24 17:35:02 I think the reason you have flashing chrome at sta
bshe 2016/08/26 18:20:24 hah. That explains. Thanks!
+ android:windowSoftInputMode="stateAlwaysHidden"
+ android:launchMode="singleTask"
+ android:screenOrientation="landscape"
+ android:hardwareAccelerated="false"
+ android:exported="true">
+ <intent-filter>
+ <action android:name="android.intent.action.MAIN" />
+ <category android:name="android.intent.category.LAUNCHER" />
+ <!-- Show icon in Daydream app launcher. -->
+ <category android:name="com.google.intent.category.DAYDREAM" />
+ </intent-filter>
+ </activity>
+ {% endif %}
<activity android:name="org.chromium.chrome.browser.ChromeTabbedActivity2"
android:theme="@style/TabbedModeTheme"
android:exported="false"
« no previous file with comments | « chrome/android/chrome_public_apk_tmpl.gni ('k') | chrome/android/java/src/org/chromium/chrome/browser/VrActivity.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698