chrome/browser/resources/welcome/welcome.js - Issue 2252063002: Adding client code for new desktop First Run Experience.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/welcome/welcome.js

Issue 2252063002: Adding client code for new desktop First Run Experience. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing michaelpg comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/welcome/welcome.html ('K') | « chrome/browser/resources/welcome/welcome.html ('k') | chrome/browser/ui/BUILD.gn » ('j') | chrome/browser/ui/webui/welcome_ui.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/welcome/welcome.js

diff --git a/chrome/test/data/extensions/api_test/executescript/http204/at_document_start_unexpected.js b/chrome/browser/resources/welcome/welcome.js

similarity index 74%

copy from chrome/test/data/extensions/api_test/executescript/http204/at_document_start_unexpected.js

copy to chrome/browser/resources/welcome/welcome.js

index 4f8dbf131e67f59d4c7f8e1bb3fc2c38f4f85ef8..102537742e9aff3fbbeb2106553d968d56fa75e5 100644

--- a/chrome/test/data/extensions/api_test/executescript/http204/at_document_start_unexpected.js

+++ b/chrome/browser/resources/welcome/welcome.js

@@ -2,4 +2,5 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

-window.didRunAtDocumentStartUnexpected = true;

+// TODO(tmartino): Add handlers.

+console.log('JS test');

« chrome/browser/resources/welcome/welcome.html ('K') | « chrome/browser/resources/welcome/welcome.html ('k') | chrome/browser/ui/BUILD.gn » ('j') | chrome/browser/ui/webui/welcome_ui.h » ('J')