chrome/browser/ui/webui/welcome_ui.h - Issue 2252063002: Adding client code for new desktop First Run Experience.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/webui/welcome_ui.h

Issue 2252063002: Adding client code for new desktop First Run Experience. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixing build issues after rebasing Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc ('K') | « chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc ('k') | chrome/browser/ui/webui/welcome_ui.cc » ('j') | chrome/browser/ui/webui/welcome_ui.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
	michaelpg 2016/09/06 22:21:57 throughout: no (c): https://chromium.googlesource. throughout: no (c): https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md... tmartino 2016/09/07 23:06:43 Done Show quoted text On 2016/09/06 at 22:21:57, michaelpg wrote: > throughout: no (c): https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md... Done
	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_UI_WEBUI_WELCOME_UI_H_

	6 #define CHROME_BROWSER_UI_WEBUI_WELCOME_UI_H_

	7

	8 #include "content/public/browser/web_ui_controller.h"

	9 #include "url/gurl.h"

	10

	11 // The WebUI for chrome://welcome, the page which greets new Desktop users and

	12 // promotes sign-in.

	13

	14 class WelcomeUI : public content::WebUIController {

	15 public:

	16 explicit WelcomeUI(content::WebUI* web_ui, const GURL& url);
	michaelpg 2016/09/06 22:21:57 omit explicit for multi-arg constructors: https:// omit explicit for multi-arg constructors: https://engdoc.corp.google.com/eng/doc/devguide/cpp/styleguide.shtml?cl=head#... tmartino 2016/09/07 23:06:43 Done Show quoted text On 2016/09/06 at 22:21:57, michaelpg wrote: > omit explicit for multi-arg constructors: https://engdoc.corp.google.com/eng/doc/devguide/cpp/styleguide.shtml?cl=head#... Done
	17 ~WelcomeUI() override;

	18 };

	19

	20 #endif // CHROME_BROWSER_UI_WEBUI_WELCOME_UI_H_

OLD	NEW