Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 2252043002: Gerrit git cl upload: auto-filter patchset titles. (Closed)

Created:
4 years, 4 months ago by tandrii(chromium)
Modified:
4 years, 4 months ago
Reviewers:
Bons
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, tandrii+omg_git_cl_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Gerrit git cl upload: auto-filter patchset titles. Without it, upload fails because ref is invalid. BUG=622062 R=andybons@chromium.org Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/eefe83265b93d55c024f23d58b3f8f45affab8dc

Patch Set 1 #

Total comments: 2

Patch Set 2 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M git_cl.py View 1 1 chunk +6 lines, -2 lines 0 comments Download
M tests/git_cl_test.py View 1 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
tandrii(chromium)
4 years, 4 months ago (2016-08-17 13:57:40 UTC) #1
tandrii(chromium)
PTAL
4 years, 4 months ago (2016-08-17 16:29:22 UTC) #8
Bons
lgtm https://codereview.chromium.org/2252043002/diff/1/git_cl.py File git_cl.py (right): https://codereview.chromium.org/2252043002/diff/1/git_cl.py#newcode2523 git_cl.py:2523: 'and space. Cleaned up title:\n%s' % options.title) and ...
4 years, 4 months ago (2016-08-17 16:48:19 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2252043002/20001
4 years, 4 months ago (2016-08-17 17:09:10 UTC) #12
tandrii(chromium)
Done.
4 years, 4 months ago (2016-08-17 17:09:27 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 17:12:28 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/eefe83265b93d5...

Powered by Google App Engine
This is Rietveld 408576698