Mojo Spy core first cut

Mojo Spy core first CL. Introduces mojo::Spy files

Currently only the most basic interception of message pipes.

See design document:
https://docs.google.com/a/chromium.org/document/d/11FKYXf9mSohlsgl4JmGlyWE1ScX3DKdssdjub63tkwA/edit#heading=h.fi6hmvi95gtz

BUG=360188
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262209

[cpu_(ooo_6.6-7.5), 2014-04-04 20:58:19]

Just the most basic stuff. PTAL.

[DaveMoore, 2014-04-04 21:06:45]

LGTM after issues noted are cleaned up.

https://codereview.chromium.org/225203002/diff/20001/mojo/mojo.gyp
File mojo/mojo.gyp (right):

https://codereview.chromium.org/225203002/diff/20001/mojo/mojo.gyp#newcode382
mojo/mojo.gyp:382: 'type': 'static_library',
I don't think the _lib is necessary. it's on mojo_shell_lib below, but that's an
implementation detail for android and is going away. I think mojo_spy is fine.

https://codereview.chromium.org/225203002/diff/20001/mojo/service_manager/ser...
File mojo/service_manager/service_manager.cc (right):

https://codereview.chromium.org/225203002/diff/20001/mojo/service_manager/ser...
mojo/service_manager/service_manager.cc:105: if (interceptor_)
Please include braces even if it's one statement on multiple lines.

https://codereview.chromium.org/225203002/diff/20001/mojo/service_manager/ser...
File mojo/service_manager/service_manager.h (right):

https://codereview.chromium.org/225203002/diff/20001/mojo/service_manager/ser...
mojo/service_manager/service_manager.h:25: // Interface class for
testing/debugging only.
This should either be a nested class within ServiceManager
(ServiceManager::Interceptor) or defined in a separate file. I prefer the
former.

https://codereview.chromium.org/225203002/diff/20001/mojo/spy/spy.cc
File mojo/spy/spy.cc (right):

https://codereview.chromium.org/225203002/diff/20001/mojo/spy/spy.cc#newcode40
mojo/spy/spy.cc:40: 
Nit: Extra blank line

https://codereview.chromium.org/225203002/diff/20001/mojo/spy/spy.cc#newcode52
mojo/spy/spy.cc:52: // 1- Wait for an empoint to have a message.
Nit: endpoint?

https://codereview.chromium.org/225203002/diff/20001/mojo/spy/spy.cc#newcode84
mojo/spy/spy.cc:84: if(!CheckResult(Wait(write_handle,
Nit: space after if

https://codereview.chromium.org/225203002/diff/20001/mojo/spy/spy.cc#newcode89
mojo/spy/spy.cc:89: if(!CheckResult(WriteMessageRaw(write_handle,
Nit: space after if

[cpu_(ooo_6.6-7.5), 2014-04-04 23:42:44]

all very sensible comments. done.

https://codereview.chromium.org/225203002/diff/20001/mojo/mojo.gyp
File mojo/mojo.gyp (right):

https://codereview.chromium.org/225203002/diff/20001/mojo/mojo.gyp#newcode382
mojo/mojo.gyp:382: 'type': 'static_library',
On 2014/04/04 21:06:46, DaveMoore wrote:
> I don't think the _lib is necessary. it's on mojo_shell_lib below, but that's
an
> implementation detail for android and is going away. I think mojo_spy is fine.

Done.

https://codereview.chromium.org/225203002/diff/20001/mojo/service_manager/ser...
File mojo/service_manager/service_manager.cc (right):

https://codereview.chromium.org/225203002/diff/20001/mojo/service_manager/ser...
mojo/service_manager/service_manager.cc:105: if (interceptor_)
On 2014/04/04 21:06:46, DaveMoore wrote:
> Please include braces even if it's one statement on multiple lines.

Done.

https://codereview.chromium.org/225203002/diff/20001/mojo/service_manager/ser...
File mojo/service_manager/service_manager.h (right):

https://codereview.chromium.org/225203002/diff/20001/mojo/service_manager/ser...
mojo/service_manager/service_manager.h:25: // Interface class for
testing/debugging only.
On 2014/04/04 21:06:46, DaveMoore wrote:
> This should either be a nested class within ServiceManager
> (ServiceManager::Interceptor) or defined in a separate file. I prefer the
> former.

Done.

https://codereview.chromium.org/225203002/diff/20001/mojo/spy/spy.cc
File mojo/spy/spy.cc (right):

https://codereview.chromium.org/225203002/diff/20001/mojo/spy/spy.cc#newcode40
mojo/spy/spy.cc:40: 
On 2014/04/04 21:06:46, DaveMoore wrote:
> Nit: Extra blank line

Done.

https://codereview.chromium.org/225203002/diff/20001/mojo/spy/spy.cc#newcode52
mojo/spy/spy.cc:52: // 1- Wait for an empoint to have a message.
On 2014/04/04 21:06:46, DaveMoore wrote:
> Nit: endpoint?

Done.

https://codereview.chromium.org/225203002/diff/20001/mojo/spy/spy.cc#newcode84
mojo/spy/spy.cc:84: if(!CheckResult(Wait(write_handle,
On 2014/04/04 21:06:46, DaveMoore wrote:
> Nit: space after if

Done.

https://codereview.chromium.org/225203002/diff/20001/mojo/spy/spy.cc#newcode89
mojo/spy/spy.cc:89: if(!CheckResult(WriteMessageRaw(write_handle,
On 2014/04/04 21:06:46, DaveMoore wrote:
> Nit: space after if

Done.

[cpu_(ooo_6.6-7.5), 2014-04-05 01:35:55]

I'll address darin's comments in a follow up patch if any.

[cpu_(ooo_6.6-7.5), 2014-04-05 01:36:03]

The CQ bit was checked by cpu@chromium.org

[commit-bot: I haz the power, 2014-04-05 01:36:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cpu@chromium.org/225203002/40001

[commit-bot: I haz the power, 2014-04-05 02:40:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-05 02:40:59]

Retried try job too often on android_dbg for step(s) slave_steps
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[cpu_(ooo_6.6-7.5), 2014-04-07 17:42:49]

The CQ bit was checked by cpu@chromium.org

[commit-bot: I haz the power, 2014-04-07 17:42:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cpu@chromium.org/225203002/60001

[commit-bot: I haz the power, 2014-04-07 22:04:48]

Change committed as 262209