Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: media/gpu/ipc/service/gpu_video_encode_accelerator.h

Issue 2251993004: media/.../{android_,gpu_}video_encode_accelerator{,_host} cleanup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/gpu/ipc/service/gpu_video_encode_accelerator.h
diff --git a/media/gpu/ipc/service/gpu_video_encode_accelerator.h b/media/gpu/ipc/service/gpu_video_encode_accelerator.h
index c928d6e985862415ea134e3475ae7e8c3c024982..ab6840ea09fb37daeb9efff8d0b2504e6ac8adc7 100644
--- a/media/gpu/ipc/service/gpu_video_encode_accelerator.h
+++ b/media/gpu/ipc/service/gpu_video_encode_accelerator.h
@@ -74,28 +74,11 @@ class GpuVideoEncodeAccelerator
const gpu::GpuPreferences& gpu_preferences);
private:
- typedef std::unique_ptr<VideoEncodeAccelerator> (*CreateVEAFp)();
-
- // Return a set of VEA Create function pointers applicable to the current
- // platform.
- static std::vector<CreateVEAFp> CreateVEAFps(
+ // Return a vector of of VEA actory methods for the current platform.
+ using VEAFactoryMethod =
+ base::Callback<std::unique_ptr<VideoEncodeAccelerator>()>;
+ static std::vector<VEAFactoryMethod> GetVEAFactoryMethods(
watk 2016/08/18 18:12:15 nit: calling these methods is slightly misleading
mcasas 2016/08/18 19:24:40 Done.
const gpu::GpuPreferences& gpu_preferences);
-#if defined(OS_CHROMEOS) && defined(USE_V4L2_CODEC)
- static std::unique_ptr<VideoEncodeAccelerator> CreateV4L2VEA();
-#endif
-#if defined(OS_CHROMEOS) && defined(ARCH_CPU_X86_FAMILY)
- static std::unique_ptr<VideoEncodeAccelerator> CreateVaapiVEA();
-#endif
-#if defined(OS_ANDROID) && defined(ENABLE_WEBRTC)
- static std::unique_ptr<VideoEncodeAccelerator> CreateAndroidVEA();
-#endif
-#if defined(OS_MACOSX)
- static std::unique_ptr<VideoEncodeAccelerator> CreateVTVEA();
-#endif
-#if defined(OS_WIN)
- static std::unique_ptr<media::VideoEncodeAccelerator>
- CreateMediaFoundationVEA();
-#endif
// IPC handlers, proxying VideoEncodeAccelerator for the renderer
// process.

Powered by Google App Engine
This is Rietveld 408576698