[heap] Filter slots in map space

src/heap/remembered-set.cc

Index: src/heap/remembered-set.cc
diff --git a/src/heap/remembered-set.cc b/src/heap/remembered-set.cc
index 8d3957bb4dca80f35d536fccbc62c062e794c33d..97ad3763ac06bfe143bdd0376d26d2b479101d89 100644
--- a/src/heap/remembered-set.cc
+++ b/src/heap/remembered-set.cc
@@ -39,17 +39,13 @@ void RememberedSet<direction>::ClearInvalidSlots(Heap* heap) {
           });
     }
   }
-  if (Heap::ShouldZapGarbage()) {
-    // Need to filter invalid slots as we overwrite them with zap values in
-    // during sweeping which runs concurrently with pointer updating.
-    for (MemoryChunk* chunk : *heap->map_space()) {
-      SlotSet* slots = GetSlotSet(chunk);
-      if (slots != nullptr) {
-        slots->Iterate([heap, chunk](Address addr) {
-          Object** slot = reinterpret_cast<Object**>(addr);
-          return IsValidSlot(heap, chunk, slot) ? KEEP_SLOT : REMOVE_SLOT;
-        });
-      }
+  for (MemoryChunk* chunk : *heap->map_space()) {
+    SlotSet* slots = GetSlotSet(chunk);
+    if (slots != nullptr) {
+      slots->Iterate([heap, chunk](Address addr) {
+        Object** slot = reinterpret_cast<Object**>(addr);
+        return IsValidSlot(heap, chunk, slot) ? KEEP_SLOT : REMOVE_SLOT;

[Hannes Payer (out of office), 2016/08/17 11:51:25]

For map spaces all allocations should be map aligned. With that we could easily
calculate the start of the object cheaply. Can we add a TODO that says that and
can we fix that in a follow-up CL?

[Michael Lippautz, 2016/08/17 12:16:17]

Done.

+      });
     }
   }
 }