Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 2251973004: PlzNavigate: Triage tests failing due to flipped WebFrameClient callbacks (Closed)

Created:
4 years, 4 months ago by blundell
Modified:
4 years, 4 months ago
Reviewers:
clamy
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove_passing_tests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PlzNavigate: Triage tests failing due to flipped WebFrameClient callbacks As described in crbug.com/638900, when running in PlzNavigate the order of the WebFrameClient and didStartProvisionalLoad() and didFinishDocumentLoad() callbacks is inverted from non-PlzNavigate when loading a subframe while parsing the document. This inversion causes these layout tests to fail because they see WebFrameTestClient's output from these callbacks in the opposite order from what's expected. BUG=638900 Committed: https://crrev.com/321db6cd62126d6a12de04ea8b874d3b7f10adad Cr-Commit-Position: refs/heads/master@{#413102}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation View 2 chunks +9 lines, -5 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
blundell
4 years, 4 months ago (2016-08-18 12:02:28 UTC) #2
clamy
Thanks! Lgtm
4 years, 4 months ago (2016-08-18 12:03:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2251973004/1
4 years, 4 months ago (2016-08-19 07:19:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-19 10:55:18 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-19 10:58:34 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/321db6cd62126d6a12de04ea8b874d3b7f10adad
Cr-Commit-Position: refs/heads/master@{#413102}

Powered by Google App Engine
This is Rietveld 408576698