third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerThread.h - Issue 2251903002: Destruct base::Thread before WorkerThread::terminateAndWait returns

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerThread.h

Issue 2251903002: Destruct base::Thread before WorkerThread::terminateAndWait returns (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/compositorworker/AbstractAnimationWorkletThread.h ('K') | « third_party/WebKit/Source/modules/compositorworker/AbstractAnimationWorkletThread.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerThread.h

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerThread.h b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerThread.h

index 1a3718f1136e6a6c8628de7a6bd3977abfa4262e..7f91ea10397af2b961e1156c1be4b120b0999906 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerThread.h

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerThread.h

@@ -45,6 +45,7 @@ public:

~ServiceWorkerThread() override;

WorkerBackingThread& workerBackingThread() override { return *m_workerBackingThread; }

+ void clearWorkerBackingThread() override {}

nhiroki 2016/08/17 07:24:19 Why don't we nullify the thread here?

haraken 2016/08/17 08:02:34 Done.

protected:

WorkerOrWorkletGlobalScope* createWorkerGlobalScope(std::unique_ptr<WorkerThreadStartupData>) override;