Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerThread.cpp

Issue 2251903002: Destruct base::Thread before WorkerThread::terminateAndWait returns (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: temp Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerThread.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 ServiceWorkerThread::ServiceWorkerThread(PassRefPtr<WorkerLoaderProxy> workerLoa derProxy, WorkerReportingProxy& workerReportingProxy) 46 ServiceWorkerThread::ServiceWorkerThread(PassRefPtr<WorkerLoaderProxy> workerLoa derProxy, WorkerReportingProxy& workerReportingProxy)
47 : WorkerThread(workerLoaderProxy, workerReportingProxy) 47 : WorkerThread(workerLoaderProxy, workerReportingProxy)
48 , m_workerBackingThread(WorkerBackingThread::create("ServiceWorker Thread")) 48 , m_workerBackingThread(WorkerBackingThread::create("ServiceWorker Thread"))
49 { 49 {
50 } 50 }
51 51
52 ServiceWorkerThread::~ServiceWorkerThread() 52 ServiceWorkerThread::~ServiceWorkerThread()
53 { 53 {
54 } 54 }
55 55
56 void ServiceWorkerThread::clearWorkerBackingThread()
57 {
58 m_workerBackingThread = nullptr;
59 }
60
56 WorkerOrWorkletGlobalScope* ServiceWorkerThread::createWorkerGlobalScope(std::un ique_ptr<WorkerThreadStartupData> startupData) 61 WorkerOrWorkletGlobalScope* ServiceWorkerThread::createWorkerGlobalScope(std::un ique_ptr<WorkerThreadStartupData> startupData)
57 { 62 {
58 return ServiceWorkerGlobalScope::create(this, std::move(startupData)); 63 return ServiceWorkerGlobalScope::create(this, std::move(startupData));
59 } 64 }
60 65
61 } // namespace blink 66 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerThread.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698