Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: third_party/WebKit/Source/modules/compositorworker/AbstractAnimationWorkletThread.h

Issue 2251903002: Destruct base::Thread before WorkerThread::terminateAndWait returns (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: temp Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef AbstractAnimationWorkletThread_h 5 #ifndef AbstractAnimationWorkletThread_h
6 #define AbstractAnimationWorkletThread_h 6 #define AbstractAnimationWorkletThread_h
7 7
8 #include "core/workers/WorkerLoaderProxy.h" 8 #include "core/workers/WorkerLoaderProxy.h"
9 #include "core/workers/WorkerThread.h" 9 #include "core/workers/WorkerThread.h"
10 #include "modules/ModulesExport.h" 10 #include "modules/ModulesExport.h"
11 #include <memory> 11 #include <memory>
12 12
13 namespace blink { 13 namespace blink {
14 14
15 class WorkerReportingProxy; 15 class WorkerReportingProxy;
16 16
17 // TODO(ikilpatrick): Remove this class up to AnimationWorkletThread once we no 17 // TODO(ikilpatrick): Remove this class up to AnimationWorkletThread once we no
18 // longer have CompositorWorker. 18 // longer have CompositorWorker.
19 class MODULES_EXPORT AbstractAnimationWorkletThread : public WorkerThread { 19 class MODULES_EXPORT AbstractAnimationWorkletThread : public WorkerThread {
20 public: 20 public:
21 ~AbstractAnimationWorkletThread() override; 21 ~AbstractAnimationWorkletThread() override;
22 22
23 WorkerBackingThread& workerBackingThread() override; 23 WorkerBackingThread& workerBackingThread() override;
24 void clearWorkerBackingThread() override
25 {
26 // Do nothing.
27 // The backing thread is cleared by clearSharedBackingThread().
28 }
29
24 bool shouldAttachThreadDebugger() const override { return false; } 30 bool shouldAttachThreadDebugger() const override { return false; }
25 31
26 static void ensureSharedBackingThread(); 32 static void ensureSharedBackingThread();
27 static void createSharedBackingThreadForTest(); 33 static void createSharedBackingThreadForTest();
28 34
29 static void clearSharedBackingThread(); 35 static void clearSharedBackingThread();
30 36
31 protected: 37 protected:
32 AbstractAnimationWorkletThread(PassRefPtr<WorkerLoaderProxy>, WorkerReportin gProxy&); 38 AbstractAnimationWorkletThread(PassRefPtr<WorkerLoaderProxy>, WorkerReportin gProxy&);
33 39
34 bool isOwningBackingThread() const override { return false; } 40 bool isOwningBackingThread() const override { return false; }
35 }; 41 };
36 42
37 } // namespace blink 43 } // namespace blink
38 44
39 #endif // AbstractAnimationWorkletThread_h 45 #endif // AbstractAnimationWorkletThread_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698