ui/gfx/platform_font_win.h - Issue 2251893004: Use parameterized tests to test multiple render text implementations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/platform_font_win.h

Issue 2251893004: Use parameterized tests to test multiple render text implementations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@selection_direction

Patch Set: Address nits. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/gfx/platform_font_win.h

diff --git a/ui/gfx/platform_font_win.h b/ui/gfx/platform_font_win.h

index e5aa9bc79d3b2abe7ca7463803ec20618c75c829..ac4f664080224645683e040aaba99e8ea83a2f0a 100644

--- a/ui/gfx/platform_font_win.h

+++ b/ui/gfx/platform_font_win.h

@@ -80,7 +80,7 @@ class GFX_EXPORT PlatformFontWin : public PlatformFont {

static int GetFontSize(const LOGFONT& font_info);

private:

- FRIEND_TEST_ALL_PREFIXES(RenderTextTest, HarfBuzz_UniscribeFallback);

+ FRIEND_TEST_ALL_PREFIXES(RenderTextHarfBuzzTest, HarfBuzz_UniscribeFallback);

FRIEND_TEST_ALL_PREFIXES(PlatformFontWinTest, Metrics_SkiaVersusGDI);

FRIEND_TEST_ALL_PREFIXES(PlatformFontWinTest, DirectWriteFontSubstitution);

@@ -128,7 +128,8 @@ class GFX_EXPORT PlatformFontWin : public PlatformFont {

private:

friend class base::RefCounted<HFontRef>;

- FRIEND_TEST_ALL_PREFIXES(RenderTextTest, HarfBuzz_UniscribeFallback);

+ FRIEND_TEST_ALL_PREFIXES(RenderTextHarfBuzzTest,

+ HarfBuzz_UniscribeFallback);

FRIEND_TEST_ALL_PREFIXES(PlatformFontWinTest, Metrics_SkiaVersusGDI);

FRIEND_TEST_ALL_PREFIXES(PlatformFontWinTest, DirectWriteFontSubstitution);

« no previous file with comments | « tools/valgrind/gtest_exclude/ui_base_unittests.gtest-memcheck.txt ('k') | ui/gfx/render_text.h » ('j') | ui/gfx/render_text_unittest.cc » ('J')