tools/valgrind/gtest_exclude/ui_base_unittests.gtest-memcheck.txt - Issue 2251893004: Use parameterized tests to test multiple render text implementations.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/valgrind/gtest_exclude/ui_base_unittests.gtest-memcheck.txt

Issue 2251893004: Use parameterized tests to test multiple render text implementations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@selection_direction

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # http://crbug.com/222606	1 # http://crbug.com/222606

2 RenderTextTest.DisplayRectShowsCursorLTR	2 RenderTextHarfBuzzTest.DisplayRectShowsCursorLTR
	msw 2016/08/25 03:02:19 I wonder if we can remove this exclusion; the cite I wonder if we can remove this exclusion; the cited bug is closed (but not directly related?) karandeepb 2016/08/25 08:13:10 I am also not sure. Since the cited bug is closed, Show quoted text On 2016/08/25 03:02:19, msw wrote: > I wonder if we can remove this exclusion; the cited bug is closed (but not > directly related?) I am also not sure. Since the cited bug is closed, we can probably see if removing this causes a failure. That way we can at least file a new bug. msw 2016/08/25 15:20:37 Sorry, I should have suggested trying this in a se Show quoted text On 2016/08/25 08:13:10, karandeepb wrote: > On 2016/08/25 03:02:19, msw wrote: > > I wonder if we can remove this exclusion; the cited bug is closed (but not > > directly related?) > > I am also not sure. Since the cited bug is closed, we can probably see if > removing this causes a failure. That way we can at least file a new bug. Sorry, I should have suggested trying this in a separate CL, I'll feel bad if this CL were reverted just because of this speculative change. karandeepb 2016/08/26 00:47:29 Sure, will do this in a separate change. Show quoted text On 2016/08/25 15:20:37, msw wrote: > On 2016/08/25 08:13:10, karandeepb wrote: > > On 2016/08/25 03:02:19, msw wrote: > > > I wonder if we can remove this exclusion; the cited bug is closed (but not > > > directly related?) > > > > I am also not sure. Since the cited bug is closed, we can probably see if > > removing this causes a failure. That way we can at least file a new bug. > > Sorry, I should have suggested trying this in a separate CL, I'll feel bad if > this CL were reverted just because of this speculative change. Sure, will do this in a separate change.
3	3

4 # http://crbug.com/370168	4 # http://crbug.com/370168

5 TouchExplorationTest.*	5 TouchExplorationTest.*

6	6

7 # http://crbug.com/414191	7 # http://crbug.com/414191

8 MenuControllerTest.OpenClose	8 MenuControllerTest.OpenClose

OLD	NEW

« no previous file with comments | « no previous file | ui/gfx/platform_font_win.h » ('j') | ui/gfx/render_text.h » ('J')