Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2251893003:
Possible fix for autoclick test flakes. (Closed)
|
Created:
4 years, 4 months ago by jdufault Modified:
4 years, 4 months ago Reviewers:
James Cook CC:
chromium-reviews, kalyank, sadrul Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionPossible fix for autoclick test flakes.
The display was being initialized non-deterministicly before. When the display is initialized, it generates some input events which cause the test to fail. This CL makes sure the display is fully initialized before starting the test.
TEST=ash_unittests
BUG=638670
Committed: https://crrev.com/4fecc95b4947643d1c1ba8e30eafe516e10696cf
Cr-Commit-Position: refs/heads/master@{#412888}
Patch Set 1 #
Messages
Total messages: 17 (11 generated)
The CQ bit was checked by jdufault@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Possible fix for autoclick test flakes. BUG=638670 ========== to ========== Possible fix for autoclick test flakes. BUG=638670 ==========
jdufault@chromium.org changed reviewers: + jamescook@chromium.org
jamescook@ PTAL. Thanks!
LGTM but please update description. All descriptions should include why the change is being made (your title is sufficient) and a brief summary of what you did. They should also include a TEST= line, with at least the affected test suite. For example, TEST=ash_unittests
Description was changed from ========== Possible fix for autoclick test flakes. BUG=638670 ========== to ========== Possible fix for autoclick test flakes. The display was being initialized non-deterministicly before. When the display is initialized, it generates some input events which cause the test to fail. TEST=ash_unittests BUG=638670 ==========
Description was changed from ========== Possible fix for autoclick test flakes. The display was being initialized non-deterministicly before. When the display is initialized, it generates some input events which cause the test to fail. TEST=ash_unittests BUG=638670 ========== to ========== Possible fix for autoclick test flakes. The display was being initialized non-deterministicly before. When the display is initialized, it generates some input events which cause the test to fail. This CL makes sure the display is fully initialized before starting the test. TEST=ash_unittests BUG=638670 ==========
On 2016/08/18 15:58:09, James Cook (slow reviews) wrote: > LGTM but please update description. All descriptions should include why the > change is being made (your title is sufficient) and a brief summary of what you > did. They should also include a TEST= line, with at least the affected test > suite. For example, TEST=ash_unittests Done - thanks!
The CQ bit was checked by jdufault@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Possible fix for autoclick test flakes. The display was being initialized non-deterministicly before. When the display is initialized, it generates some input events which cause the test to fail. This CL makes sure the display is fully initialized before starting the test. TEST=ash_unittests BUG=638670 ========== to ========== Possible fix for autoclick test flakes. The display was being initialized non-deterministicly before. When the display is initialized, it generates some input events which cause the test to fail. This CL makes sure the display is fully initialized before starting the test. TEST=ash_unittests BUG=638670 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Possible fix for autoclick test flakes. The display was being initialized non-deterministicly before. When the display is initialized, it generates some input events which cause the test to fail. This CL makes sure the display is fully initialized before starting the test. TEST=ash_unittests BUG=638670 ========== to ========== Possible fix for autoclick test flakes. The display was being initialized non-deterministicly before. When the display is initialized, it generates some input events which cause the test to fail. This CL makes sure the display is fully initialized before starting the test. TEST=ash_unittests BUG=638670 Committed: https://crrev.com/4fecc95b4947643d1c1ba8e30eafe516e10696cf Cr-Commit-Position: refs/heads/master@{#412888} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/4fecc95b4947643d1c1ba8e30eafe516e10696cf Cr-Commit-Position: refs/heads/master@{#412888} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
