Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 2251863004: [interpreter] Fixes the collection of type feedback in the bitwise binary operator. (Closed)

Created:
4 years, 4 months ago by epertoso
Modified:
4 years, 4 months ago
Reviewers:
Jarin, *rmcilroy
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Fixes the collection of type feedback in the bitwise binary operator. The Smi case was updating the feedback with a bitwise AND instead of a bitwise OR. This was causing feedback that should have been 'kAny' to be erroneusly reported as 'kSignedSmall'. R=rmcilroy@chromium.org Committed: https://crrev.com/e82f94466fa7ee4ee6dd71598ed03a5ed9e43808 Cr-Commit-Position: refs/heads/master@{#38682}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -2 lines) Patch
M src/interpreter/interpreter-assembler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 1 chunk +55 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
epertoso
4 years, 4 months ago (2016-08-17 12:59:03 UTC) #5
rmcilroy
LGTM, thanks for the test!
4 years, 4 months ago (2016-08-17 13:28:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2251863004/1
4 years, 4 months ago (2016-08-17 13:30:36 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-17 13:32:27 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-17 13:32:45 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e82f94466fa7ee4ee6dd71598ed03a5ed9e43808
Cr-Commit-Position: refs/heads/master@{#38682}

Powered by Google App Engine
This is Rietveld 408576698