Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(645)

Unified Diff: build/android/pylib/results/json_results.py

Issue 2251863003: Add tombstones as part of json-results-file for android instr tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: moved tombstone to base test result Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/instrumentation/test_result.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/results/json_results.py
diff --git a/build/android/pylib/results/json_results.py b/build/android/pylib/results/json_results.py
index 80b3c32074f09a6e39c1254a4f74d3538b44296f..1c7b1523968375435963b9779eb09e02507b79ac 100644
--- a/build/android/pylib/results/json_results.py
+++ b/build/android/pylib/results/json_results.py
@@ -8,7 +8,6 @@ import json
from pylib.base import base_test_result
-
def GenerateResultsDict(test_run_results):
"""Create a results dict from |test_run_results| suitable for writing to JSON.
Args:
@@ -96,13 +95,18 @@ def GenerateResultsDict(test_run_results):
results_iterable = test_run_result.GetAll()
for r in results_iterable:
- iteration_data[r.GetName()].append({
+ result_dict = {
'status': status_as_string(r.GetType()),
'elapsed_time_ms': r.GetDuration(),
'output_snippet': r.GetLog(),
'losless_snippet': '',
'output_snippet_base64:': '',
- })
+ }
jbudorick 2016/08/18 19:36:18 left four spaces
BigBossZhiling 2016/08/18 22:12:06 Done.
+ if r.GetTombstones():
jbudorick 2016/08/18 19:36:18 You can consolidate this by just adding 'tombst
BigBossZhiling 2016/08/18 22:12:06 Done.
+ result_dict['tombstones'] = r.GetTombstones()
+ else:
+ result_dict['tombstones'] = ''
+ iteration_data[r.GetName()].append(result_dict)
all_tests = all_tests.union(set(iteration_data.iterkeys()))
per_iteration_data.append(iteration_data)
« no previous file with comments | « build/android/pylib/instrumentation/test_result.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698