Reland: Add MemoryCoordinatorClient

Reland: Add MemoryCoordinatorClient

Make MemoryCoordinator garbage collected to make sure that MemoryCoordinator::trace()
is called. Garbage collected MemoryCoordinatorClient will be removed from |m_clients|.

Original description:

Also move MemoryCoordinator from core/dom to platform/. This is a preparation for experimenting purge and suspend [1,2].

[1] https://docs.google.com/document/d/1EgLimgxWK5DGhptnNVbEGSvVn6Q609ZJaBkLjEPRJvI/edit
[2] https://codereview.chromium.org/2130683002/

TBR=esprehn@chromium.org,haraken@chromium.org
BUG=638274
Committed: https://crrev.com/5f4c7892122d68b2588ae2bd804fc2dc75e15596
Cr-Commit-Position: refs/heads/master@{#412966}

[bashi, 2016-08-17 23:41:30]

The CQ bit was checked by bashi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-17 23:42:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bashi, 2016-08-17 23:45:52]

bashi@chromium.org changed reviewers:
+ esprehn@chromium.org, haraken@chromium.org, keishi@chromium.org

[bashi, 2016-08-17 23:45:52]

PTAL

This reland includes https://codereview.chromium.org/2251643002/. The original
CL was reverted due to null de-reference for a member in |m_clients| and I think
making MemoryCoordinator garbage collected would fix it. Correct me if I'm
wrong.

[haraken, 2016-08-17 23:46:46]

LGTM

[commit-bot: I haz the power, 2016-08-18 00:50:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 00:50:17]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sof, 2016-08-18 05:51:05]

https://codereview.chromium.org/2251853005/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/MemoryCoordinator.cpp (right):

https://codereview.chromium.org/2251853005/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/MemoryCoordinator.cpp:10: #include
"platform/heap/Heap.h"
unnecessary.

https://codereview.chromium.org/2251853005/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/MemoryCoordinator.cpp:15:
DEFINE_TRACE(MemoryCoordinatorClient)
You don't need to define empty |trace| methods on mixins.

https://codereview.chromium.org/2251853005/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/MemoryCoordinator.cpp:21:
DEFINE_STATIC_LOCAL(Persistent<MemoryCoordinator>, external, (new
MemoryCoordinator));
Is it guaranteed that the initial thread accessing instance(), is the one owning
it (and is Oilpan attached) ?

[bashi, 2016-08-18 06:49:07]

https://codereview.chromium.org/2251853005/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/MemoryCoordinator.cpp (right):

https://codereview.chromium.org/2251853005/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/MemoryCoordinator.cpp:10: #include
"platform/heap/Heap.h"
On 2016/08/18 05:51:05, sof wrote:
> unnecessary.

Done.

https://codereview.chromium.org/2251853005/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/MemoryCoordinator.cpp:15:
DEFINE_TRACE(MemoryCoordinatorClient)
On 2016/08/18 05:51:05, sof wrote:
> You don't need to define empty |trace| methods on mixins.

Done.

https://codereview.chromium.org/2251853005/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/MemoryCoordinator.cpp:21:
DEFINE_STATIC_LOCAL(Persistent<MemoryCoordinator>, external, (new
MemoryCoordinator));
On 2016/08/18 05:51:05, sof wrote:
> Is it guaranteed that the initial thread accessing instance(), is the one
owning
> it (and is Oilpan attached) ?

IIUC yes. Only the main thread accesses instance() after blink is initialized.
Added DCHECK().

[bashi, 2016-08-18 06:49:28]

The CQ bit was checked by bashi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-18 06:49:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 08:27:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-18 08:27:51]

Dry run: This issue passed the CQ dry run.

[bashi, 2016-08-18 22:59:16]

Description was changed from

==========
Reland: Add MemoryCoordinatorClient

Make MemoryCoordinator garbage collected to make sure that
MemoryCoordinator::trace()
is called. Garbage collected MemoryCoordinatorClient will be removed from
|m_clients|.

Original description:

Also move MemoryCoordinator from core/dom to platform/. This is a preparation
for experimenting purge and suspend [1,2].

[1]
https://docs.google.com/document/d/1EgLimgxWK5DGhptnNVbEGSvVn6Q609ZJaBkLjEPRJ...
[2] https://codereview.chromium.org/2130683002/

BUG=638274
==========

to

==========
Reland: Add MemoryCoordinatorClient

Make MemoryCoordinator garbage collected to make sure that
MemoryCoordinator::trace()
is called. Garbage collected MemoryCoordinatorClient will be removed from
|m_clients|.

Original description:

Also move MemoryCoordinator from core/dom to platform/. This is a preparation
for experimenting purge and suspend [1,2].

[1]
https://docs.google.com/document/d/1EgLimgxWK5DGhptnNVbEGSvVn6Q609ZJaBkLjEPRJ...
[2] https://codereview.chromium.org/2130683002/

TBR=esprehn@chromium.org,haraken@chromium.org
BUG=638274
==========

[bashi, 2016-08-18 22:59:34]

The CQ bit was checked by bashi@chromium.org

[bashi, 2016-08-18 22:59:34]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2251853005/#ps20001
(title: "comment")

[commit-bot: I haz the power, 2016-08-18 23:00:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-18 23:06:27]

Description was changed from

==========
Reland: Add MemoryCoordinatorClient

Make MemoryCoordinator garbage collected to make sure that
MemoryCoordinator::trace()
is called. Garbage collected MemoryCoordinatorClient will be removed from
|m_clients|.

Original description:

Also move MemoryCoordinator from core/dom to platform/. This is a preparation
for experimenting purge and suspend [1,2].

[1]
https://docs.google.com/document/d/1EgLimgxWK5DGhptnNVbEGSvVn6Q609ZJaBkLjEPRJ...
[2] https://codereview.chromium.org/2130683002/

TBR=esprehn@chromium.org,haraken@chromium.org
BUG=638274
==========

to

==========
Reland: Add MemoryCoordinatorClient

Make MemoryCoordinator garbage collected to make sure that
MemoryCoordinator::trace()
is called. Garbage collected MemoryCoordinatorClient will be removed from
|m_clients|.

Original description:

Also move MemoryCoordinator from core/dom to platform/. This is a preparation
for experimenting purge and suspend [1,2].

[1]
https://docs.google.com/document/d/1EgLimgxWK5DGhptnNVbEGSvVn6Q609ZJaBkLjEPRJ...
[2] https://codereview.chromium.org/2130683002/

TBR=esprehn@chromium.org,haraken@chromium.org
BUG=638274
==========

[commit-bot: I haz the power, 2016-08-18 23:06:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-18 23:24:42]

Description was changed from

==========
Reland: Add MemoryCoordinatorClient

Make MemoryCoordinator garbage collected to make sure that
MemoryCoordinator::trace()
is called. Garbage collected MemoryCoordinatorClient will be removed from
|m_clients|.

Original description:

Also move MemoryCoordinator from core/dom to platform/. This is a preparation
for experimenting purge and suspend [1,2].

[1]
https://docs.google.com/document/d/1EgLimgxWK5DGhptnNVbEGSvVn6Q609ZJaBkLjEPRJ...
[2] https://codereview.chromium.org/2130683002/

TBR=esprehn@chromium.org,haraken@chromium.org
BUG=638274
==========

to

==========
Reland: Add MemoryCoordinatorClient

Make MemoryCoordinator garbage collected to make sure that
MemoryCoordinator::trace()
is called. Garbage collected MemoryCoordinatorClient will be removed from
|m_clients|.

Original description:

Also move MemoryCoordinator from core/dom to platform/. This is a preparation
for experimenting purge and suspend [1,2].

[1]
https://docs.google.com/document/d/1EgLimgxWK5DGhptnNVbEGSvVn6Q609ZJaBkLjEPRJ...
[2] https://codereview.chromium.org/2130683002/

TBR=esprehn@chromium.org,haraken@chromium.org
BUG=638274

Committed: https://crrev.com/5f4c7892122d68b2588ae2bd804fc2dc75e15596
Cr-Commit-Position: refs/heads/master@{#412966}
==========

[commit-bot: I haz the power, 2016-08-18 23:24:43]

Patchset 2 (id:??) landed as
https://crrev.com/5f4c7892122d68b2588ae2bd804fc2dc75e15596
Cr-Commit-Position: refs/heads/master@{#412966}