Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6358)

Unified Diff: chrome/chrome_browser.gypi

Issue 225183018: Move feedback files into src/components (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix deps, merge gyp targets, sync with latest Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/chrome_browser.gypi
diff --git a/chrome/chrome_browser.gypi b/chrome/chrome_browser.gypi
index 3344cc26dd46f78ace33e767cf3e6a103386b81f..1cda9d8a1d31fd9bd066e9cd62dd2272a8f08a9d 100644
--- a/chrome/chrome_browser.gypi
+++ b/chrome/chrome_browser.gypi
@@ -21,7 +21,6 @@
'chrome_resources.gyp:theme_resources',
'common',
'common_net',
- 'feedback_proto',
'in_memory_url_index_cache_proto',
'probe_message_proto',
'safe_browsing_proto',
@@ -34,6 +33,7 @@
'../components/components.gyp:domain_reliability',
'../components/components.gyp:favicon_base',
'../components/components.gyp:favicon_core',
+ '../components/components.gyp:feedback_component',
'../components/components.gyp:infobars_core',
'../components/components.gyp:navigation_metrics',
'../components/components.gyp:os_crypt',
@@ -363,22 +363,9 @@
'browser/browsing_data/browsing_data_cookie_helper.h',
'browser/browsing_data/cookies_tree_model.cc',
'browser/browsing_data/cookies_tree_model.h',
- 'browser/feedback/feedback_data.cc',
- 'browser/feedback/feedback_data.h',
'browser/feedback/feedback_profile_observer.cc',
'browser/feedback/feedback_profile_observer.h',
- 'browser/feedback/feedback_report.cc',
- 'browser/feedback/feedback_report.h',
- 'browser/feedback/feedback_util.cc',
- 'browser/feedback/feedback_util.h',
- 'browser/feedback/feedback_uploader.cc',
- 'browser/feedback/feedback_uploader.h',
- 'browser/feedback/feedback_uploader_chrome.cc',
- 'browser/feedback/feedback_uploader_chrome.h',
- 'browser/feedback/feedback_uploader_delegate.cc',
- 'browser/feedback/feedback_uploader_delegate.h',
- 'browser/feedback/feedback_uploader_factory.cc',
- 'browser/feedback/feedback_uploader_factory.h',
+ 'browser/feedback/show_feedback_page.cc',
'browser/feedback/system_logs/about_system_logs_fetcher.cc',
'browser/feedback/system_logs/about_system_logs_fetcher.h',
'browser/feedback/system_logs/scrubbed_system_logs_fetcher.cc',
@@ -389,8 +376,6 @@
'browser/feedback/system_logs/log_sources/chrome_internal_log_source.h',
'browser/feedback/system_logs/log_sources/memory_details_log_source.cc',
'browser/feedback/system_logs/log_sources/memory_details_log_source.h',
- 'browser/feedback/tracing_manager.cc',
- 'browser/feedback/tracing_manager.h',
'browser/captive_portal/captive_portal_detector.cc',
'browser/captive_portal/captive_portal_detector.h',
'browser/captive_portal/captive_portal_login_detector.cc',
@@ -3223,11 +3208,6 @@
'browser/download/download_shelf.cc',
'browser/download/download_shelf_context_menu.cc',
'browser/drive/drive_switches.cc',
- 'browser/feedback/proto/annotations.proto',
- 'browser/feedback/proto/chrome.proto',
- 'browser/feedback/proto/common.proto',
- 'browser/feedback/proto/dom.proto',
- 'browser/feedback/proto/math.proto',
'browser/gpu/chrome_gpu_util.cc',
'browser/idle_android.cc',
'browser/idle.cc',
@@ -3519,25 +3499,6 @@
'includes': [ '../build/protoc.gypi' ]
},
{
- # Protobuf compiler / generate rule for feedback
- 'target_name': 'feedback_proto',
- 'type': 'static_library',
- 'sources': [
- 'browser/feedback/proto/annotations.proto',
- 'browser/feedback/proto/chrome.proto',
- 'browser/feedback/proto/common.proto',
- 'browser/feedback/proto/dom.proto',
- 'browser/feedback/proto/extension.proto',
- 'browser/feedback/proto/math.proto',
- 'browser/feedback/proto/web.proto',
- ],
- 'variables': {
- 'proto_in_dir': 'browser/feedback/proto',
- 'proto_out_dir': 'chrome/browser/feedback/proto',
- },
- 'includes': [ '../build/protoc.gypi' ]
- },
- {
# Protobuf compiler / generator for the safebrowsing reporting
# protocol buffer.
'target_name': 'safe_browsing_report_proto',

Powered by Google App Engine
This is Rietveld 408576698